Checksum failure for ports that fetch using cvs/git/hg/svn

[ryandesign (Ryan Carsten Schmidt)]

With MacPorts 2.0.2, at least some ports that fetch using git fail with a checksum error. The checksum phase shouldn't even be running for ports that fetch using an scm. This is a regression from 2.0.1 which didn't have this problem.

$ sudo port extract pianobar
--->  Computing dependencies for pianobar
--->  Fetching pianobar
--->  Verifying checksum(s) for pianobar
Error: Target org.macports.checksum returned:  does not exist in /opt/local/var/macports/distfiles/pianobar
Log for pianobar is at: /opt/local/var/macports/logs/_Users_rschmidt_macports_dports_audio_pianobar/pianobar/main.log
Error: Status 1 encountered during processing.
To report a bug, see <http://guide.macports.org/#project.tickets>

$ sudo port extract git-flow
--->  Computing dependencies for git-flow
--->  Fetching git-flow
--->  Verifying checksum(s) for git-flow
Error: Target org.macports.checksum returned:  does not exist in /opt/local/var/macports/distfiles/git-flow
Log for git-flow is at: /opt/local/var/macports/logs/_Users_rschmidt_macports_dports_devel_git-flow/git-flow/main.log
Error: Status 1 encountered during processing.
To report a bug, see <http://guide.macports.org/#project.tickets>

$ sudo port extract yajl
--->  Computing dependencies for yajl
--->  Fetching yajl
--->  Verifying checksum(s) for yajl
Error: Target org.macports.checksum returned:  does not exist in /opt/local/var/macports/distfiles/yajl
Log for yajl is at: /opt/local/var/macports/logs/_Users_rschmidt_macports_dports_devel_yajl/yajl/main.log
Error: Status 1 encountered during processing.
To report a bug, see <http://guide.macports.org/#project.tickets>

$ sudo port extract ffmpeg-devel
--->  Computing dependencies for ffmpeg-devel
--->  Fetching ffmpeg-devel
--->  Verifying checksum(s) for ffmpeg-devel
Error: Target org.macports.checksum returned:  does not exist in /opt/local/var/macports/distfiles/ffmpeg-devel
Log for ffmpeg-devel is at: /opt/local/var/macports/logs/_Users_rschmidt_macports_dports_multimedia_ffmpeg-devel/ffmpeg-devel/main.log
Error: Status 1 encountered during processing.
To report a bug, see <http://guide.macports.org/#project.tickets>

Curiously, other ports that fetch using git aren't affected, including:

• libhsplasma
• liblrdf
• xorg-server-devel

The only change that I think happened to checksumming in 2.0.2 is r83149 (#28568).

[ryandesign (Ryan Carsten Schmidt)]

I also see the problem with ports using other SCMs:

• cvs (cableswig, but not Chmox, sheepshaver or maven)
• hg (BWToolkit and go, but not iulib or ocropus)
• svn (couchdb-devel, iTerm, iTerm2, rgm3800 and taglib-devel, but not CronniX)

I didn't see the problem with bzr, but we only have one port with that fetch type.

[macports@…]

The problem is the default setting of distfiles, which as of r83149 creates a list even if portfetch::suffix returns an empty string. I've attached a fix.

[afb@…]

It would be "nice" if the checksum/digest didn't change, just because one chooses a different compression or archiver or method of transportation... For instance, by using a file manifest ?

[kyle@…]

FYI, the patch worked great here.

[ak.ml@…]

Cc Me!

[ryandesign (Ryan Carsten Schmidt)]

Replying to afb@…:

It would be "nice" if the checksum/digest didn't change, just because one chooses a different compression or archiver or method of transportation... For instance, by using a file manifest ?

That doesn't seem relevant to this ticket.

[ryandesign (Ryan Carsten Schmidt)]

Replying to macports@…:

The problem is the default setting of distfiles, which as of r83149 creates a list even if portfetch::suffix returns an empty string. I've attached a fix.

It looks like a fix was committed in r83471. Duplicates #31078 (qjson) and #31091 (dbusmenu-qt) have already been filed; we should release MacPorts 2.0.3 with this fix ASAP rather than fixing each port individually (as has already begun with qjson).

[rick@…]

As the submitter of ticket:31091 I agree with ryandesign@… - individual fixes are not the way to go as they will not solve the underlying problem.

If I knew how to withdraw ticket:31091 I certainly would.

[jmroot (Joshua Root)]

I'm on holiday at the moment.

[oi@…]

Patch worked here also

[ryandesign (Ryan Carsten Schmidt)]

Replying to oi@…:

Patch worked here also

We're not using that patch; we're using what was committed in r83471.

[ryandesign (Ryan Carsten Schmidt)]

Has duplicate #31135.

[rick@…]

Replying to ryandesign@…:
Patch works for me

[ryandesign (Ryan Carsten Schmidt)]

Replying to rick@…:

Patch works for me

Again, we are not going to be using the patch attached to this ticket; we're using what has already been committed in r83471 and which will be released in MacPorts 2.0.3.

[raimue (Rainer Müller)]

MacPorts 2.0.3 has been released.