Updated ports for xfce 4.8

[ak.ml@…]

I followed the build guideline ​http://xfce.org/download/building#dependencies

Core components:

• exo
• garcon [new]
• gtk-xfce-engine
• libxfce4ui [new]
• libxfce4util
• libxfcegui4 [deprecated]
• Thunar
• xfce-utils
• xfce4-appfinder
• xfce4-panel
• xfce4-session
• xfce4-settings
• xfconf
• xfdesktop
• xfwm4

Applications:

• orage
• ristretto
• Terminal

Attached:

• Combined diff of modified Portfiles, I kept the indentation as it was in hope that it would make it easier to review.
• New Portfiles for garcon and libxfce4ui
• New patchfile: xfce/libxfcegui4/files/patch-environ.diff
• Updated patchfile: xfce/Terminal/files/patch-terminal-Makefile.in

I removed the following patchfiles:

xfce/exo/files/exo-mmintrin.diff
xfce/Thunar/files/patch-configure-snow.diff
xfce/Thunar/files/patch-thunar-metafile.c
xfce/xfce4-panel/files/config-launcher-icons.diff
xfce/xfce4-panel/files/fix-xfce-bug-6110.diff
xfce/xfce4-settings/files/patch-configure.diff
xfce/xfce4-settings/files/patch-workspaces.c

Remarks:

• I haven't updated xfce metaport but I can come up with something if you like. By the way I would refer to Xfce (which would need an update as well) for the setup instructions. I would use notes for the setup instructions.
• If this gets committed, I'd appreciate if it was consistently indented, and modelines were added
• You can add me as co-maintainer
• ristretto doesn't work for me: I can't select any file for display

[ak.ml@…]

Cobined diff for updated ports

[ak.ml@…]

garcon's Portfile

[ak.ml@…]

libxfce4ui's Portfile

[ak.ml@…]

xfce/libxfcegui4/files/patch-environ.diff

[ak.ml@…]

xfce/Terminal/files/patch-terminal-Makefile.in

[ak.ml@…]

I thought I had kept the indentation as it was but didn't.

[afb@…]

I thought I had kept the indentation as it was but didn't.

It could be changed to spaces, if you're allergic to tabs.

[afb@…]

All the ports will also need to have "license" added (for distribution), after "platforms".

[ak.ml@…]

I wasn't aware of that when I updated the Portfiles in the first place. However I still can't tell the difference between GPL-2 and GPL-2+

[afb@…]

Replying to ak.ml@…:

I wasn't aware of that when I updated the Portfiles in the first place. However I still can't tell the difference between GPL-2 and GPL-2+

The only way to tell is to look at the header of the actual source code... If it says "or (at your option) any later version" it's +.

[ak.ml@…]

Any status update?
There were several updates on the XFCE side, especially for ristretto @0.1.1 which now works.

[afb@…]

I got side-tracked, but tabs-to-spaces and licenses were done.

[ak.ml@…]

Replying to afb@…:

I got side-tracked, but tabs-to-spaces and licenses were done.

Thanks for the reply.
You made a lot of changes in depends_build for the buildbot I guess.
Is this still a work in progress?
Are there other steps before you actually update to Xfce 4.8?

[afb@…]

You made a lot of changes in depends_build for the buildbot I guess.
Is this still a work in progress?

There shouldn't be any more such changes needed (to 4.6), I think.

Are there other steps before you actually update to Xfce 4.8?

Nope, except that all ports must be updated at once due to deps...

[ryandesign (Ryan Carsten Schmidt)]

This update may fix #32596 and #32651.

[ryandesign (Ryan Carsten Schmidt)]

Anders, will you do this update?

[afb@…]

I think it was mostly ready to go, but not submitted... Maybe it should be, if someone wanted to look at 4.10 ?

[cooljeanius (Eric Gallager)]

Cc Me!

[cooljeanius (Eric Gallager)]

r107757 noted that a bunch of the xfce ports were broken...

[afb@…]

Seems like r107757 noted that intltool is broken ? But yeah, it also noted that xfce ports are outdated.

[jeremyhu (Jeremy Huddleston Sequoia)]

This patch no longer applies, but a quick comment anyways...

patch-environ.diff is wrong. You should just #include <crt_externs.h> rather than declaring that yourself.

[jeremyhu (Jeremy Huddleston Sequoia)]

updates core xfce libs to 4.10 versions

[jeremyhu (Jeremy Huddleston Sequoia)]

I spent a few minutes on this updating the core libraries (patch attached). Someone else needs to pick up the torch and complete the work if they care about having xfce in MacPorts.

[afb@…]

Replying to jeremyhu@…:

This patch no longer applies, but a quick comment anyways...

patch-environ.diff is wrong. You should just #include <crt_externs.h> rather than declaring that yourself.

Sounds right. Not sure that it actually matters, those definitions/that file isn't updated much.

[afb@…]

Replying to jeremyhu@…:

I spent a few minutes on this updating the core libraries (patch attached). Someone else needs to pick up the torch and complete the work if they care about having xfce in MacPorts.

I don't really care about fixing Xfce, but I think I have enough patches for it. Or maybe it's more that I don't care if it works from MacPorts ports, but anyway...

If anyone else want to maintain, feel free to apply (again). Meanwhile, I'll fix it.

[afb@…]

Seems like people keep filing and updating bugs on Xfce, guess it should be updated and tested on Mavericks...

It can probably "borrow" some stuff from ​http://svnweb.freebsd.org/ports/head/x11-wm/xfce4/ and its friends ?

[afb@…]

Fixed, r144133.

Skipped the existing 4.8, took a jump over 4.10 and went straight for 4.12. Removed Terminal and Midori from the standard install, to simplify things...