Ticket #31288 (closed defect: fixed)
libelf needs '--disable-compat' to fix headers
| Reported by: | adfernandes@… | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.0.3 |
| Keywords: | haspatch | Cc: | jstrine@… |
| Port: | libelf |
Description
In bug #14955, conflicting nlist.h headers were handled by deleting the nlist.h used by libelf.
This is incorrect; both elf and mach-o have an "nlist.h" that are incompatible. The system's is at /usr/include/nlist.h for mach-o formatted objects.
Libelf http://www.mr511.de/software/libelf-0.8.0.README has a "compatibility mode" where the headers are put in ${prefix}/usr/include/libelf, and this is preferred on OS X.
Patch attached. Okay to commit?
Attachments
Change History
comment:1 Changed 20 months ago by ryandesign@…
- Keywords haspatch added
When the version is increased, the revision should drop to zero.
comment:2 Changed 20 months ago by ryandesign@…
Hopefully you mean ${prefix}/include/libelf; ${prefix}/usr/include/libelf would be rather strange.
comment:3 Changed 20 months ago by adfernandes@…
Ah - thanks, Ryan - I keep forgetting that pesky revision number. Fixed on my repository. Also, yes, I also meant ${prefix}/usr/include/libelf as you thought.
Although - talk about strange paths - I need this for some arm/elf arm/macho cross-compilation tools... and I've learned that "rather strange" is no reason to not do something, when it comes to object-file formats! :-)
comment:4 Changed 20 months ago by adfernandes@…
- Status changed from new to closed
- Resolution set to fixed
Whups! I was working on new ports before my morning tea and accidentally committed this patch. (I needed it for the new py27-pylibelf port.)
Hope I didn't step on toes - just wanted to blame my bad etiquette on insufficient morning caffeine.
-A.