Update py27-pyfits to 3.0.2

[marshall.perrin@…]

The attached portfile updated pyfits to the latest version, 3.0.2. Despite this being a bump of the major version number, I found that it installed flawlessly with only trivial updates to the Portfile.

The other py*-pyfits portfile variants should be updated. In addition, pyfits 3 now compiles under Python 3, so new variants py31-pyfits etc could now be created.

[marshall.perrin@…]

Portfile for pyfits 3.0.2

[mf2k (Frank Schima)]

Please attach a unified diff instead of a complete Portfile so we can see your changes.

The best way to keep all the py*-fits ports updated is to unify them into a single portfile.

[marshall.perrin@…]

Oho! I had not seen that unified portfiles for py* ports is now possible. Superb, I've been wanting that for a long while. I will update my portfile accordingly and upload a diff of that.

[cdeil (Christoph Deil)]

Cc Me!

[cdeil (Christoph Deil)]

I have created a single Portfile that works for python 2.5, 2.6, 2.7, 3.1 and 3.2 and updated to the current stable version 3.0.4. I have removed all the pyXX-pyfits directories and put the new Portfile in a directory py-pyfits. Then after running portindex I could install and import pyfits with all python versions (except 2.4 which is not supported by pyfits).

For me clang was used and there are a few -Wunused-function warnings that are irrelevant but could be reported to the pyfits dev.

Also there are a bunch of warnings which I think are normal for python modules, but I'm not sure: {{{./bin missing (created) ./etc missing (created) ./include missing (created) ./lib missing (created) ./lib/pkgconfig missing (created) ./libexec missing (created) ./sbin missing (created) ./share missing (created) ./share/info missing (created) ./share/man missing (created) ./share/man/cat1 missing (created) ./share/man/cat2 missing (created) ./share/man/cat3 missing (created) }}}

Finally I get the following warnings on pyfits import from ipython (in python there is no warning):

In [1]: import pyfits
/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/pyfits/__init__.py:6: UserWarning: Module readline was already imported from /Users/deil/Library/Python/2.7/lib/python/site-packages/IPython/utils/rlineimpl.pyc, but /opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/readline is being added to sys.path
  import pkg_resources
/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/pyfits/__init__.py:6: UserWarning: Module argparse was already imported from /opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/argparse.pyc, but /Users/deil/Library/Python/2.7/lib/python/site-packages is being added to sys.path
  import pkg_resources

Note that I had the same two warnings when I had installed pyfits from SVN HEAD outside Macports, so this might be a problem of my setup only.

I don't know if pyfits has unit tests or how to run them, that would of course be the best check.

So overall: I think the attached Portfile is fine and you can submit it. :-)

[mf2k (Frank Schima)]

The depends_lib-append needs to be in a

if {$subport != $name} {

block. Also, given that sebastien.maret has not responded to this thread, I'm not sure we should set him as the maintainer.

[mf2k (Frank Schima)]

Also, we need to add a license field.

[mf2k (Frank Schima)]

Also, I see the following error that I am not able to remove.

Error: Unknown dependency: py24-pyfits

[mf2k (Frank Schima)]

Added with slight improvements in r88331. Thanks! If you can tell me the license, I will add it to the portfile. I've set the maintainer to nomaintainer.

[robitaille@…]

The license looks like a 3-clause BSD license: ​http://www.stsci.edu/resources/software_hardware/pyraf/LICENSE