New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #31588 (closed update: fixed)

Opened 20 months ago

Last modified 15 months ago

grisbi @0.6.0 update to version 0.8.8

Reported by: gerald@… Owned by: ryandesign@…
Priority: Normal Milestone:
Component: ports Version: 2.0.3
Keywords: haspatch maintainer Cc: devans@…
Port: grisbi

Description

Update Portfile to version 0.8.8 of Grisbi.

Attachments

Portfile-grisbi.diff (1.5 KB) - added by gerald@… 20 months ago.
patch-grisbi-Portfile.diff (2.0 KB) - added by devans@… 18 months ago.
Revised patch for Portfile
grisbi-ryandesign.diff (2.2 KB) - added by ryandesign@… 18 months ago.
proposed patch

Change History

Changed 20 months ago by gerald@…

comment:1 Changed 20 months ago by ryandesign@…

  • Keywords haspatch maintainer added
  • Status changed from new to assigned
  • Port set to grisbi
  • Owner changed from macports-tickets@… to ryandesign@…

Thanks. There are several changes I'd suggest. I'll attach a new patch and explain and you can see what you think.

comment:2 Changed 18 months ago by devans@…

Since this has been sitting for a while, here is an updated patch for the Portfile for review and comment by both of you (see attached)

  • remove configure.args that are either the default or no longer recognized
  • add --disable-silent-rules to make debugging easier
  • add build dependencies on pkgconfig and intltool which are required
  • convert lib-style lib dependencies to port dependencies to ensure only using MacPorts versions of these libraries
  • remove universal_variant yes -- this is the default
  • remove supported archs statement since there doesn't seem to be any restriction on arch
  • fix livecheck
  • add license

Ryan may have some other suggestions

Changed 18 months ago by devans@…

Revised patch for Portfile

comment:3 Changed 18 months ago by devans@…

  • Cc devans@… added

Cc Me!

comment:4 Changed 18 months ago by ryandesign@…

Sorry, I forgot about this. Additional comments:

  • master_sites sourceforge should be rewritten to avoid redirects
  • the no_ofx variant should be deprecated and turned into an on-by-default ofx variant; the no_ofx variant can be deleted in a year or so once everyone has upgraded to this new version
  • the livecheck should be able to discover new stable branches of the software
  • we prefer rmd160 & sha256 checksum types

I've attached a new update, which is almost ready, except that grisbi has a bug where it will use ofx, even if you ask it not to; I filed upstream bug 1432 about this.

Ideally I'd also like to make a second commit later to fix the port's whitespace and formatting to conform to the modeline and our usual formatting practices.

Changed 18 months ago by ryandesign@…

proposed patch

comment:5 Changed 15 months ago by raimue@…

  • Status changed from assigned to closed
  • Resolution set to fixed

Committed proposed patch in r90310.

Note: See TracTickets for help on using tickets.