BUG: Larn does not build on Tiger

[dhjr@…]

Thebes:rec% port build ---> Fetching larn ---> Attempting to fetch larn-4.6.2-RELEASE.tar.bz2 from ​http://distfiles-od.opendarwin.org/ ---> Verifying checksum(s) for larn ---> Extracting larn ---> Applying patches to larn ---> Configuring larn ---> Building larn with target all Error: Target com.apple.build returned: shell command "cd "/Users/dhjr/darwinports/dports/games/larn/work/larn" && bsdmake all LDADD+=-L/opt/local/lib\ -lcompat\ -lncurses" returned error 1 Command output: Warning: Object directory not changed from original /Users/dhjr/darwinports/dports/games/larn/work/larn cc -O -pipe -DBSD -DVER=12 -DSUBVER=0 -DNONAP -DUIDSCORE -fwritable-strings -c main.c In file included from main.c:5: header.h:329:1: warning: "NULL" redefined In file included from header.h:4,

from main.c:5:

/usr/include/stdlib.h:114:1: warning: this is the location of the previous definition main.c: In function 'main': main.c:75: warning: incompatible implicit declaration of built-in function 'sprintf' main.c:135: warning: incompatible implicit declaration of built-in function 'sscanf' main.c:144: warning: incompatible implicit declaration of built-in function 'printf' cc -O -pipe -DBSD -DVER=12 -DSUBVER=0 -DNONAP -DUIDSCORE -fwritable-strings -c object.c In file included from object.c:3: header.h:329:1: warning: "NULL" redefined In file included from header.h:4,

from object.c:3:

/usr/include/stdlib.h:114:1: warning: this is the location of the previous definition object.c: In function 'adjtime': object.c:538: error: argument 'tim' doesn't match prototype /usr/include/sys/time.h:234: error: prototype declaration object.c:538: error: number of arguments doesn't match prototype /usr/include/sys/time.h:234: error: prototype declaration object.c: In function 'read_scroll': object.c:578: warning: passing argument 1 of 'adjtime' makes pointer from integer without a cast object.c:578: error: too few arguments to function 'adjtime' * Error code 1

gcc --version powerpc-apple-darwin8-gcc-4.0.0 (GCC) 4.0.0 20041026 (Apple Computer, Inc. build 4061)

[aschenke@…]

I think I have this fixed for 10.4. There were two major problems. First, the "adjtime" function was conflicting with the name of a function from sys/time.h. I patched Larn to use the function name "larn_adjtime" instead. The second problem is that varargs.h no longer works with GCC 4.0 and later. I have patched the code to use stdarg.h instead, which required changes to the various lprintf calls so that the number of parameters passed by the caller is the first argument. There are also various Portfile changes as well.

[aschenke@…]

New portfile for larn

[aschenke@…]

New patch files for Larn (12 total); zip archive

[aschenke@…]

Additional notes:

The ${prefix}/var/games/larn directory, where scores and logs are stored, is not created. This is due to the directory being empty when it is destrooted. Also, I'm not sure what the owner, group and permissions should be for this directory. There is no default "games" user as of Tiger.

The program appears to work correctly, but I have only tested it briefly.

[aschenke@…]

Portfile patch for larn 4.6_2

[aschenke@…]

Portfile patch for larn 4.6

[aschenke@…]

I have confirmation from at least one user that the above patches work for Tiger on Intel. If possible, could we get these committed?

[markd@…]

Changes committed. Thanks! I could only test it on PPC but since no once else stepped up I went ahead. Others will have to test it on Intel.