Opened 12 years ago
Closed 11 years ago
#31852 closed enhancement (fixed)
fontforge: add python variants
| Reported by: | michael@… | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.0.3 |
| Keywords: | haspatch | Cc: | su-v, mojca (Mojca Miklavec), patrick@…, derekathomas@…, jmaibaum@… |
| Port: | fontforge |
Description
This patch adds variants to the fontforge port for enabling Python support, both as a Python module and as an embedded scripting language. There are two (conflicting) variants, one for Python 2.6 and the other for Python 2.7.
Attachments (4)
Change History (14)
Changed 12 years ago by michael@…
| Attachment: | Portfile-fontforge.diff added |
|---|
Changed 12 years ago by michael@…
| Attachment: | patch-Makefile.dynamic.in.diff added |
|---|
comment:1 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
| Keywords: | haspatch added |
|---|---|
| Summary: | Add Python support to FontForge → fontforge: add python variants |
comment:2 Changed 12 years ago by michael@…
comment:6 Changed 12 years ago by jmroot (Joshua Root)
Looks OK for the most part, but applicationsdir = /Applications is incorrect. The $applications_dir portfile variable needs to be inserted there.
Also might want to add --no-user-cfg to the setup.py args. And JFYI you don't need to use a separate configure.args-append call for each arg.
Note that comments on a ticket are only seen by the people on Cc (and the owner, when there is one). So you're much better off to ping the macports-dev list if a ticket seems to have been forgotten.
Changed 11 years ago by jmaibaum@…
| Attachment: | patch-Makefile.dynamic.in.2.diff added |
|---|
New version reflecting jmr’s advices.
Changed 11 years ago by jmaibaum@…
| Attachment: | patch-Portfile.diff added |
|---|
New version reflecting jmr’s advices.
comment:8 Changed 11 years ago by jmaibaum@…
Hey,
I’ve tested Michaels patches for the python27 variant and they work fine.
jmr, I’ve checked the last versions of the patch Makefile.dynamic.in, the line change that adds the line:
applicationsdir = /Applications
is already in there since 5 years and gets, since then, reinplaced by the post-patch hook:
reinplace "/^applicationsdir/s|/Applications|${applications_dir}|" \
${worksrcpath}/Makefile.dynamic.in
Both these changes were introduced in changeset [42222].
So the only actual change that Michael introduced is the one in line 133.
I’ve attached two new patches that reflect jmr’s advices. Hopefully they can be committed soon, since programmatically calling fontforge from Python scripts is being used extensively in many new free font projects.
Cheers, jmaibaum.
comment:10 Changed 11 years ago by neverpanic (Clemens Lang)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
In r106892, thanks for the patches.
Any update on this? If this is not the right way to add a Python module, I would appreciate any hint on how to do it.