New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #32332 (closed defect: fixed)

Opened 18 months ago

Last modified 18 months ago

vim, vim-app, MacVim: remove nls variant

Reported by: ryandesign@… Owned by: raimue@…
Priority: Normal Milestone:
Component: ports Version: 2.0.3
Keywords: haspatch Cc: florian@…
Port: vim, vim-app, MacVim

Description

In r24862 vim's gettext support was moved to a variant. MacVim inherited this when it was created in r47370. An nls variant was also snuck into the vim-app port in r32061, though that revision was described as only adding variant descriptions; indeed, vim-app does not disable nls by default. So most vim-app users probably already have nls support, though the port does not declare a dependency on gettext.

I see no reason for natural language support to be optional. This was previously mentioned in comment:ticket:32304:4. See attached patches.

Attachments

vim.diff (1.1 KB) - added by ryandesign@… 18 months ago.
proposed patch for vim
vim-app.diff (922 bytes) - added by ryandesign@… 18 months ago.
proposed patch for vim-app
MacVim.diff (1.2 KB) - added by ryandesign@… 18 months ago.
proposed patch for MacVim

Change History

Changed 18 months ago by ryandesign@…

proposed patch for vim

Changed 18 months ago by ryandesign@…

proposed patch for vim-app

Changed 18 months ago by ryandesign@…

proposed patch for MacVim

comment:1 Changed 18 months ago by raimue@…

  • Status changed from new to closed
  • Resolution set to fixed

I agree that +nls isn't really necessary and most users will already have gettext as a dependency for other ports anyway.

Thank you for your patches, committed in r87675.

Note: See TracTickets for help on using tickets.