Opened 12 years ago
Closed 8 years ago
#32914 closed update (fixed)
tin: port update to 2.0.1
| Reported by: | nefar@… | Owned by: | ryandesign (Ryan Carsten Schmidt) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch | Cc: | petrrr, kurthindenburg (Kurt Hindenburg) |
| Port: | tin |
Description
Attachments (2)
Change History (11)
Changed 12 years ago by nefar@…
| Attachment: | Portfile.patch added |
|---|
comment:1 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
| Owner: | changed from macports-tickets@… to ryandesign@… |
|---|---|
| Status: | new → assigned |
Changed 12 years ago by nefar@…
| Attachment: | Portfile.2.patch added |
|---|
comment:2 Changed 12 years ago by nefar@…
I didn't even notice the whitespace screwing up the aligning until I viewed the patch file after uploading. Sorry about that. It was a mess with tabs and spaces intermingled.
I've uploaded a new version. It doesn't have perfect white-spacing, but it's better.
comment:3 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
The new patch again combines whitespace with functional changes.
I'm already working on updating the port, so just hang tight.
Note that there are also ports tin-devel and tin-recent which I am trying to consider simultaneously.
comment:6 Changed 9 years ago by petrrr
| Cc: | Peter.Danecek@… removed |
|---|---|
| Version: | 2.0.3 |
comment:7 Changed 9 years ago by petrrr
This port is still tin @1.8.3_3, the most recent stable release seems to be 2.2.1 from 2014-05-04 (http://www.tin.org/history.html). Can we move directly to 2.2? Or would this break dependencies which need the older version?
After updating tin-devel and tin-recent, could be replaced_by tin.
comment:9 Changed 8 years ago by kurthindenburg (Kurt Hindenburg)
| Cc: | khindenburg@… added |
|---|---|
| Resolution: | → fixed |
| Status: | assigned → closed |
I've updated tin to 2.4.0 and tin-devel to 2.3.4 - tin-recent has been obsoleted - please open a new ticket for any further issues.
The only functional changes your patch contains are changing the version from 1.8.3 to 2.0.1 and updating the checksums.
You forgot to drop the revision line.
The master_sites still contain many URLs that seem to be specific to the 1.8 branch, and do not contain the 2.0.1 distfile; these should be removed or updated.
The largest problem with your patch is that you also changed the whitespace of the entire portfile. We want to commit any whitespace changes separately from functional changes, so that functional changes are easier to see, and whitespace changes can be ignored. And if you're going to change a port's whitespace, it should be to make it conform with our recommended style, which is indents at multiples of four spaces, and columns neatly lined up.