New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #32942 (closed enhancement: fixed)

Opened 16 months ago

Last modified 16 months ago

phpsh: use tarball

Reported by: ryandesign@… Owned by: singingwolfboy@…
Priority: Normal Milestone:
Component: ports Version: 2.0.3
Keywords: haspatch Cc:
Port: phpsh

Description

In r89095 I updated phpsh to use the new github portgroup. Is there a reason why this port is fetching from git and not from a tarball? It seems to build fine using a tarball. Here's a patch that would do that. Let me know if there's any reason not to commit this.

Attachments

phpsh.diff​ (863 bytes) - added by ryandesign@… 16 months ago.
proposed patch

Change History

Changed 16 months ago by ryandesign@…

proposed patch

comment:1 Changed 16 months ago by singingwolfboy@…

  • Status changed from new to closed
  • Resolution set to invalid

That patch doesn't work: Macports doesn't know where to download the file from. When you test the patch to see if it works, make sure you run `sudo port clean --all phpsh` if you're doing changes to how the sources are fetched -- otherwise, Macports will use the already-downloaded source files still sitting on your hard drive.

comment:2 Changed 16 months ago by singingwolfboy@…

  • Status changed from closed to reopened
  • Resolution invalid deleted

I was mistaken -- this patch does work, after all. Committed in r89185.

comment:3 Changed 16 months ago by singingwolfboy@…

  • Status changed from reopened to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.