New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #32970 (closed defect: fixed)

Opened 17 months ago

Last modified 17 months ago

iodine should be UsingTheRightCompiler

Reported by: snc@… Owned by: tomhennigan@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: iodine

Description

cc -c -g -Wall -DDARWIN -pedantic tun.c -o tun.o
cc: Error: You should be using ${configure.cc}
See http://trac.macports.org/wiki/UsingTheRightCompiler
make[1]: *** [tun.o] Error 1
make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_net_iodine/iodine/work/iodine-0.6.0-rc1/src'

Attachments

Portfile (1.0 KB) - added by tomhennigan@… 17 months ago.
Updated version of iodine Portfile
Portfile.diff (1.3 KB) - added by snc@… 17 months ago.
non-whitespace diff from: svn diff -x -w Portfile

Change History

Changed 17 months ago by tomhennigan@…

Updated version of iodine Portfile

comment:1 Changed 17 months ago by tomhennigan@…

I've updated the Portfile and attached it above. jann@… previously committed the portfile and patch I sent up so this ticket should now be attached to them or someone else from the ports team to review.

comment:2 Changed 17 months ago by raimue@…

Port updates are preferred to be submitted as unified diffs. In this case, you did not only fix the bug in question, but also changed large parts of whitespace in the Portfile. This makes it hard to see what was actually changed. Please submit a separate diff for the changes involving whitespace only.

Changed 17 months ago by snc@…

non-whitespace diff from: svn diff -x -w Portfile

comment:3 Changed 17 months ago by snc@…

I'll start testing your patch, also supplied a non-whitespace diff for easier viewing.

comment:4 Changed 17 months ago by snc@…

  • Status changed from new to closed
  • Resolution set to fixed

Also added missing platforms: r89234.

Note: See TracTickets for help on using tickets.