New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #33236 (closed submission: fixed)

Opened 16 months ago

Last modified 16 months ago

New port: jpegoptim

Reported by: jingoro@… Owned by: ryandesign@…
Priority: Normal Milestone:
Component: ports Version: 2.0.3
Keywords: Cc:
Port: jpegoptim

Description

Please add jpegoptim to MacPorts.

Attachments

Portfile (875 bytes) - added by jingoro@… 16 months ago.

Change History

Changed 16 months ago by jingoro@…

comment:1 Changed 16 months ago by ryandesign@…

  • Status changed from new to assigned
  • Owner changed from macports-tickets@… to ryandesign@…
  • Port set to jpegoptim

Thanks.

comment:2 Changed 16 months ago by ryandesign@…

  • Status changed from assigned to closed
  • Resolution set to fixed

I committed it in r89845 with these changes:

  • Adjusted whitespace to 4 spaces per indent
  • Added standard modeline
  • Set the maintainers field to your complete email address, in our obfuscated format
  • Changed the license field to "GPL-2+" because the source says "or (at your option) any later version"
  • Switched to rmd160 and sha256 checksum types
  • Removed configure.cppflags and configure.ldflags because the values you specified are the defaults MacPorts automatically sets for all ports
  • Removed "--with-libjpeg=${prefix}/lib" from configure.args because that's not correct (should have been "--with-libjpeg=${prefix}") and isn't necessary because of the existing cppflags and ldflags
  • Removed "--prefix=${destroot}${prefix}" from configure.args because MacPorts already puts "--prefix=${prefix}" in configure.pre_args for you, and although the software's Makefile does not support the DESTROOT variable MacPorts sets, it supports the INSTALL_ROOT variable which it uses for the same purpose, so I set "destroot.destdir INSTALL_ROOT=${destroot}" instead

comment:3 Changed 16 months ago by jingoro@…

Thanks Ryan. The feedback is much appreciated.

Note: See TracTickets for help on using tickets.