Opened 12 years ago
Closed 12 years ago
#33487 closed update (fixed)
opencore-amr @0.1.3 update
| Reported by: | janstary (Jan Starý) | Owned by: | drkp (Dan Ports) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch maintainer | Cc: | |
| Port: | openore-amr |
Description
Recently, a new version of opencore-amr was relased. Attached is a diff to the Portfile that brings the port up to this version. Tested on 10.5.8.
Attachments (2)
Change History (11)
Changed 12 years ago by janstary (Jan Starý)
| Attachment: | Portfile.diff added |
|---|
comment:1 Changed 12 years ago by janstary (Jan Starý)
comment:2 Changed 12 years ago by mf2k (Frank Schima)
| Keywords: | maintainer, haspatch → haspatch maintainer |
|---|---|
| Version: | 2.0.4 |
Your patch is not unified diff. Please use the -u flag when making a patch as per the guide.
comment:4 Changed 12 years ago by mf2k (Frank Schima)
Thanks but it looks the same as the original patch and still is not unified.
comment:5 Changed 12 years ago by janstary (Jan Starý)
Aaargh, sorry, uploaded the right one now, rewriting Portfile-opencore-amr.diff
comment:6 Changed 12 years ago by mf2k (Frank Schima)
Thanks, that's better. One minor issue, you replaced the sha256 checksum with a sha1 checksum. Please use the sha256 checksum.
Changed 12 years ago by janstary (Jan Starý)
| Attachment: | Portfile-opencore-amr.diff added |
|---|
comment:7 Changed 12 years ago by janstary (Jan Starý)
Updated.
Is there any particular reason why sha256 is preffered (or, for that matter, why rmd160 is preffered, as I often see in Portfiles)?
comment:8 Changed 12 years ago by drkp (Dan Ports)
| Owner: | changed from macports-tickets@… to dports@… |
|---|---|
| Status: | new → assigned |
comment:9 Changed 12 years ago by drkp (Dan Ports)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Thanks, applied in r90552.
sha256 is preferred over sha1 because it's a stronger hash. We like to have two different hashes in case one of them is broken; usually that's sha256 and rmd160 unless there's a good reason to do otherwise.
This is also relevant to the recent update of SoX to 14.4.0, which depends on opencore-amr. Everything seems to work with the new port of SoX on 10.5.8.