pgplot: add gcc46 variant

[Russell-Jones-OxPhys (Russell Jones)]

Added in attached portfile.

[Russell-Jones-OxPhys (Russell Jones)]

Add gcc46 variant.

[ryandesign (Ryan Carsten Schmidt)]

In the future please provide a unified diff of your changes instead of a complete new Portfile; this will make it easier for us to review your changes.

The line "build.env-append F77=${fc} F90=${fc}" that you added to the gcc43 variant does not belong; it breaks that variant.

Your've also changed the whitespace of some of the lines. While I agree with changing the port's whitespace because it is currently a mix of tabs and spaces at 2-space multiples, neither of which conforms to the modeline which says the port uses multiple-of-4-space indents, whitespace changes should be made separately from functional changes.

[ryandesign (Ryan Carsten Schmidt)]

You also changed the description of the g95 variant from "build with g95" to "build with gfortran from f95". There are two problems with this: 1) the port is called g95, not f95; 2) the g95 port provides a program called g95, not gfortran (only gcc provides gfortran). So the previous variant description was correct, and should not have been changed.

[ryandesign (Ryan Carsten Schmidt)]

Added gcc46 variant in r90816 and made whitespace and reformatting changes in r90817.

[Russell-Jones-OxPhys (Russell Jones)]

Replying to ryandesign@…:

You also changed the description of the g95 variant from "build with g95" to "build with gfortran from f95". There are two problems with this: 1) the port is called g95, not f95; 2) the g95 port provides a program called g95, not gfortran (only gcc provides gfortran). So the previous variant description was correct, and should not have been changed.

Thanks for sorting out my Portfile n00bishness. I'll take more care to get it right on my next submission.