Ticket #33828 (closed update: fixed)
ncview: update to 2.1.1
| Reported by: | rachid.benshila@… | Owned by: | ryandesign@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch | Cc: | jim.biard@… |
| Port: | ncview |
Description
Please find attached a patch for an update of ncview portfile to ncview 2.1.1. I also join a modified patch for configure. Since it's a major release for ncview (with additional dependencies), I also join the full Portfile in case you wish to add it as a separate port.
Finally, it's the first time ever I'm editing a portfile, so I apologize for potential mistakes and I would modify it happily.
Attachments
Change History
comment:1 Changed 14 months ago by macsforever2000@…
- Keywords haspatch added; ncview removed
- Version 2.0.4 deleted
comment:2 Changed 14 months ago by ryandesign@…
Since you appear to be more familiar with the ncview software than we are, could you help us decide: is there any reason why a user would still want to use ncview 1.x when version 2.2.1 is available? That would be the deciding factor for whether we update the ncview port, or add a new ncview2 port.
comment:3 Changed 14 months ago by rachid.benshila@…
I don't see any reason on ncview side, there is nothing feasible by ncview 1.x that ncview 2.x can't do, there is no incompatibility in term of input file format, and they won't be any new version 1.x. The caution relies only on the more complex dependencies involved for version 2.x, which makes an installation by hand more complicated.
By the way I opened the ticket with subject version 2.2.1, and mentioned in the ticket version 2.1.1, correct version is 2.1.1.
comment:4 Changed 14 months ago by ryandesign@…
- Summary changed from update of ncview to 2.2.1 to ncview: update to 2.1.1
comment:5 Changed 10 months ago by jmr@…
Is there a reason you want to link to libpng statically? If not, the equivalent of libpng.so is actually libpng.dylib. Also, revision should reset to 0 with a new version.
comment:6 Changed 7 months ago by ryandesign@…
- Status changed from new to assigned
- Owner changed from macports-tickets@… to ryandesign@…
comment:7 Changed 7 months ago by ryandesign@…
- Status changed from assigned to closed
- Resolution set to fixed
Changed 7 months ago by rachid.benshila@…
- Attachment patch-configure.2.diff added
new confure por ncview to work with all gcc
comment:8 follow-up: ↓ 9 Changed 7 months ago by rachid.benshila@…
- Status changed from closed to reopened
- Resolution fixed deleted
Thanks for adding this. I found there was some possible inconsistancy in the configure file depending of the version of gcc, I should not be needed with macport. Above is the new parch-configure (relative to officcial ncview original one)
comment:9 in reply to: ↑ 8 Changed 7 months ago by ryandesign@…
Replying to rachid.benshila@…:
Thanks for adding this. I found there was some possible inconsistancy in the configure file depending of the version of gcc, I should not be needed with macport.
Does it actually cause a problem for MacPorts though? If not maybe we can just wait until upstream fixes it.
Your new patch again replaces libpng.so with libpng.a instead of libpng.dylib, which Joshua had asked above why you did, which you didn't answer before.
comment:10 Changed 7 months ago by rachid.benshila@…
Apologizes for libpng, there is not reason to link statically with it (I restarted from an old version). For the gcc thing, it actually causes pb with macport when users already have installed netcdf4 with opempi, the configure doesn't recognize mpicc is just a wrapper for gcc and the installation fails.
comment:11 follow-up: ↓ 12 Changed 7 months ago by jim.biard@…
This is completely broken on my mac running OSX 1.8.2. I upgraded netcdf, and that worked just fine, then the upgrade of ncview failed. I uninstalled ncview and tried to reinstall it, and it still fails. The log indicates that the build is failing because the configure script doesn't like the compiler (same problem as was reported in this ticket). Ncview 1.9 (the last version I had installed) never had this problem.
comment:12 in reply to: ↑ 11 Changed 7 months ago by ryandesign@…
- Cc jim.biard@… added
- Status changed from reopened to closed
- Resolution set to fixed
Replying to rachid.benshila@…:
Apologizes for libpng, there is not reason to link statically with it (I restarted from an old version). For the gcc thing, it actually causes pb with macport when users already have installed netcdf4 with opempi, the configure doesn't recognize mpicc is just a wrapper for gcc and the installation fails.
I committed a modified version of the patch that did not revert the dynamic libpng linking in r99347.
Replying to jim.biard@…:
This is completely broken on my mac running OSX 1.8.2. I upgraded netcdf, and that worked just fine, then the upgrade of ncview failed. I uninstalled ncview and tried to reinstall it, and it still fails. The log indicates that the build is failing because the configure script doesn't like the compiler (same problem as was reported in this ticket). Ncview 1.9 (the last version I had installed) never had this problem.
Since this ticket was about updating the port to 2.1.1, and that has been accomplished, let's call this ticket closed now. If there are additional problems, please open a new ticket.