webkit-gtk @1.6.3 - Build failure

[l.wayne.james@…]

I am trying to build webkit-gtk as a pre-requisite to gimp2.

Variants: (+)quartz, [+]svg, (-)universal, [+]video

Build is failing with:

  CXX    Source/WebCore/platform/gtk/libWebCoreGtk_la-GeolocationServiceGtk.lo
Source/WebCore/platform/gtk/GtkWidgetBackingStoreX11.cpp:27:30: error: cairo/cairo-xlib.h: No such file or directory
Source/WebCore/platform/gtk/GtkWidgetBackingStoreX11.cpp:29:22: error: gdk/gdkx.h: No such file or directory
  CXX    Source/WebCore/platform/gtk/libWebCoreGtk_la-GOwnPtrGtk.lo
Source/WebCore/platform/gtk/GtkWidgetBackingStoreX11.cpp: In constructor 'WebCore::WidgetBackingStorePrivate::WidgetBackingStorePrivate(GtkWidget*, const WebCore::IntSize&)':
Source/WebCore/platform/gtk/GtkWidgetBackingStoreX11.cpp:62: error: 'GDK_SCREEN_XDISPLAY' was not declared in this scope
Source/WebCore/platform/gtk/GtkWidgetBackingStoreX11.cpp:64: error: 'GDK_WINDOW_XID' was not declared in this scope
Source/WebCore/platform/gtk/GtkWidgetBackingStoreX11.cpp:70: error: 'GDK_VISUAL_XVISUAL' was not declared in this scope
Source/WebCore/platform/gtk/GtkWidgetBackingStoreX11.cpp:71: error: 'cairo_xlib_surface_create' was not declared in this scope
make[1]: *** [Source/WebCore/platform/gtk/libWebCoreGtk_la-GtkWidgetBackingStoreX11.lo] Error 1

Log is attached.

[l.wayne.james@…]

Build log

[l.wayne.james@…]

Cc Me!

[l.wayne.james@…]

Changes from ticket #34086 had no effect.

[jeremyhu@…]

Replying to l.wayne.james@…:

Changes from ticket #34086 had no effect.

Well, they did have an effect. The effect was that they got past that issue and got you to a new one...

Apparently, it's trying to bring in some X11 related bits when it shouldn't...

[jeremyhu@…]

​https://bugs.webkit.org/show_bug.cgi?id=84423

[jeremyhu@…]

r92147 should address this one... hopefully that's the last one...

[l.wayne.james@…]

Replying to jeremyhu@…:

r92147 should address this one... hopefully that's the last one...

Unfortunately - in my case - it wasn't. :)

But removing "Source/WebCore/plugins/gtk/PluginViewGtk.cpp" as you did "GtkWidgetBackingStoreX11.cpp" allowed a complete build.

Please forgive my ignorance, but do you wish me to open another ticket for tracking purposes? or would a new (quartz.patch) patch attached to this one help?

I'll be able to do either (I think) as soon as gimp builds and I can confirm basic functionality.

By the way... Thank you! :D

[l.wayne.james@…]

Attaching new "quartz.patch" as promised. This allows webkit-gtk to build.

[l.wayne.james@…]

Patch to move "Source/WebCore/plugins/gtk/PluginViewGtk.cpp" into X11 build section

[ryandesign@…]

We would prefer unified diffs instead of contextual ones.

[ryandesign@…]

Has duplicate #34139.

[l.wayne.james@…]

"quartz.patch" produced by diff -u

[l.wayne.james@…]

As you wish! :)

[jeremyhu@…]

Ok, I updated it with your patch. Thanks for the help. remote debugging has massive I/O lag. =)

r92162

[pokui@…]

patches both the portfile and adds the quartz.patch so needs -p0 and to be run a dir above the port dir

[pokui@…]

r96758 added this bug back as a regression. Source/WebCore/plugins/gtk/PluginViewGtk.cpp still depends on X11.

ps: Midway my testing the patch r96855 was released without a rev bump ... made patching this interesting.

[jeremyhu@…]

Sorry. I thought upstream had already applied the patch. It's back in r96886

[dtakahashi42@…]

Could you include this small fix on quartz.patch, which resolves #35767?

@@ -10,7 +10,7 @@
  
  if TARGET_X11
  webcoregtk_sources += \
-+	Source/WebCore/plugins/gtk/PluginViewGtk.cpp
++	Source/WebCore/plugins/gtk/PluginViewGtk.cpp \
  	Source/WebCore/platform/gtk/GtkWidgetBackingStoreX11.cpp \
  	Source/WebCore/plugins/gtk/gtk2xtbin.c \
  	Source/WebCore/plugins/gtk/gtk2xtbin.h \

[jeremyhu@…]

<

r96926