Opened 12 years ago

Closed 12 years ago

#34278 closed defect (fixed)

Dominion @2.8.2 conflicting types for function 'getline'

Reported by: icaines77@… Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.0.4
Keywords: lion haspatch Cc:
Port: dominion

Description

Building dominion on OS X 10.7 fails, with error message indicating a conflicting type for getline function, which is also defined in stdio.h. Seems similar to ticket #32082. Appears to be due to Lion adding the getline function into stdio.h.

A patch to rename the offending function in Lion is attached.

Attachments (3)

main.log (5.9 KB) - added by icaines77@… 12 years ago.
log file of failed build
Portfile-dominion.diff (467 bytes) - added by icaines77@… 12 years ago.
patch to portfile
patch-getline_conflict_fix.diff (2.4 KB) - added by icaines77@… 12 years ago.
patch to rename getline() function that dominion defines.

Download all attachments as: .zip

Change History (9)

Changed 12 years ago by icaines77@…

Attachment: main.log added

log file of failed build

Changed 12 years ago by icaines77@…

Attachment: Portfile-dominion.diff added

patch to portfile

Changed 12 years ago by icaines77@…

patch to rename getline() function that dominion defines.

comment:1 Changed 12 years ago by icaines77@…

Cc: icaines77@… added

Cc Me!

comment:2 Changed 12 years ago by icaines77@…

Cc: icaines77@… removed

Cc Me!

comment:3 Changed 12 years ago by icaines77@…

Cc: icaines77@… added

Cc Me!

comment:4 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: icaines77@… removed
Keywords: haspatch added

comment:5 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned

Thanks. The patch doesn't seem to cause any problems for earlier OS versions, so I'll apply it in all cases, not just on Lion and later. This will ensure that, if a maintainer running an earlier OS version later updates the port, they won't be able to inadvertently forget to update the patch.

comment:6 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.