Ticket #34505 (closed defect: fixed)
port cmake pkg-config broken on 2.8.8
| Reported by: | and.damore@… | Owned by: | css@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.1.0 |
| Keywords: | haspatch | Cc: | |
| Port: | cmake |
Description (last modified by and.damore@…) (diff)
As per this bug report cmake 2.8.8 introduced an error, the expecting PKG_CONFIG_FOUND variable is not set when the package is found. This can be reproduced building port avidemux whose cmake configuration halts printing out "found pkg-config" and "pkg-config not found".
I'm attaching patch.
Attachments
Change History
comment:1 Changed 12 months ago by css@…
- Status changed from new to assigned
I'm going through the growing pains from a Lion upgrade, but I'll test the patch. Thanks!
comment:2 Changed 12 months ago by css@…
- Status changed from assigned to closed
- Resolution set to fixed
committed to r93702
comment:3 follow-up: ↓ 4 Changed 8 months ago by help@…
- Status changed from closed to reopened
- Resolution fixed deleted
cmake version was bumped in Portfile, but this patch wasn't dropped. In result pkg-config support in cmake broke. Please revert this change. Tested using local overlay, removing patch-Modules_FindPkgConfig_cmake.diff from patchfiles works.
comment:4 in reply to: ↑ 3 Changed 8 months ago by and.damore@…
- Status changed from reopened to closed
- Resolution set to fixed
- Description modified (diff)
Replying to help@…:
cmake version was bumped in Portfile, but this patch wasn't dropped. In result pkg-config support in cmake broke. Please revert this change. Tested using local overlay, removing patch-Modules_FindPkgConfig_cmake.diff from patchfiles works.
This ticket was correctly closed, you should have raised the point in #35882 that updated cmake in r97601, please continue discussion there.