Ticket #34666 (closed enhancement: fixed)
ace @ 6.1.2 clean up Portfile
| Reported by: | lockhart@… | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.1.1 |
| Keywords: | haspatch maintainer | Cc: | ryandesign@…, pixilla@… |
| Port: | ace |
Description
The current Portfile has some cruftiness in how variants are described. Clean this up based on detailed feedback from Ryan Schmidt. Will post patch after testing.
Attachments
Change History
comment:3 Changed 12 months ago by lockhart@…
Cleaned up based on comments from Ryan Schmidt. Includes substitution of compiler flags for the +universal variant using configure.universal_cxxflags. Ready to go.
Changed 12 months ago by lockhart@…
- Attachment Portfile-cleanup.diff added
Patch to clean up the current Portfile. Includes substitution of configure.universal_cxxflags for +universal variant. This latest version uses configure.universal_ldflags for LDFLAGS. Duh.
comment:4 Changed 12 months ago by lockhart@…
OK, even more ready to go now. The latest patch uses configure.universal_ldflags for the LDFLAGS substitution. The previous patch used _cxxflags for both compile and link stages (and on Lion they happen to be the same). Also this one explicitly patches the makefile used for the target rather than scattershotting every file I know about. Hopefully the next version of Mac OS X will work without changes but beware that sometimes the ACE and TAO developers will include a makefile from a previous version to help define the makefile for the next version of an OS. So we may need to go back to patching all files just in case.
Cc Me!