New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #34667 (closed enhancement: fixed)

Opened 12 months ago

Last modified 9 months ago

tao @6.1.2 clean up Portfile

Reported by: lockhart@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.1.1
Keywords: haspatch maintainer Cc: ryandesign@…, pixilla@…
Port: tao

Description

The TAO Portfile has cruftiness in how variants are described. Clean this up based on detailed feedback from Ryan Schmidt. Will post patches after testing.

Attachments

Portfile-cleanup.diff (5.7 KB) - added by lockhart@… 12 months ago.
Patch to clean up the current Portfile. Includes substitution of configure.universal_cxxflags for +universal variant. This latest version uses configure.universal_ldflags for LDFLAGS. Duh.

Change History

comment:1 Changed 12 months ago by lockhart@…

Cleanup of the current Portfile. Bump the revision number. Includes substitution of compiler flags using configure.universal_cxxflags when +universal is specified. Ready to go.

Changed 12 months ago by lockhart@…

Patch to clean up the current Portfile. Includes substitution of configure.universal_cxxflags for +universal variant. This latest version uses configure.universal_ldflags for LDFLAGS. Duh.

comment:2 Changed 12 months ago by lockhart@…

OK, even more ready to go now. The latest patch uses configure.universal_ldflags for the LDFLAGS substitution. The previous patch used _cxxflags for both compile and link stages (and on Lion they happen to be the same). Also this one explicitly patches the makefile used for the target rather than scattershotting every file I know about. Hopefully the next version of Mac OS X will work without changes but beware that sometimes the ACE and TAO developers will include a makefile from a previous version to help define the makefile for the next version of an OS. So we may need to go back to patching all files just in case.

comment:3 Changed 9 months ago by pixilla@…

  • Status changed from new to closed
  • Resolution set to fixed

Thanks Thomas

See r96916

Note: See TracTickets for help on using tickets.