ncarg: problem with build dependency to triangle

[petrrr]

The ncarg port has a quite weird dependency to triangle:

The port claims build time dependency to port:triangle whoever it depends on the source/distfile, not sure if it really requires triangle to be installed, but assume not.

pre-configure {
    system "cd ${workpath}/${g2clib_worksrcdir}; make all"
    file copy ${workpath}/${g2clib_worksrcdir}/libgrib2c.a ${worksrcpath}
    system "cd ${worksrcpath}/config; \
        make -f Makefile.ini; \
        ./ymake -config `pwd`"
    system "unzip -o ${prefix}/var/macports/distfiles/triangle/triangle.zip -d /tmp; \
        mv /tmp/triangle.* ${worksrcpath}/ni/src/lib/hlu"
}

The last two rows seem to unzip the distfile and copy it to the work directory. This assumes that the distfile is present. However, this might NOT be the case, if triangle is already present on the system and the distfile was purged, it won't fetch any more and the build fails.

Work-around: A port fetch triangle before the installation of ncarg solves the problem, but I guess there should be a better solution.

[ryandesign (Ryan Carsten Schmidt)]

Agreed, that is weird. Weirder that it unzips to a temporary directory in /tmp. Ports should not write temporary files outside of ${workpath}.

Better solution to the fetch issue is for ncarg to simply list triangle's distfile, just like the triangle port does. Usually in those cases it's best for the two ports to share a dist_subdir, so that users and the mirror servers don't need to download the same file twice. However, just changing, say, ncarg's dist_subdir without changing the version will cause that exact problem too, and there doesn't seem to be a newer stable version of ncarg to which the port could be updated at the same time. Triangle's distfile is pretty small, only 150K, and hasn't changed since 2005, so it's probably fine to have a second copy of it in ncarg's dist_subdir.

[tenomoto (Takeshi Enomoto)]

I attached a patch for triangle that installs triangle.c and triangle.h in $[prefix}/share/triangle. If this is allowed, ncarg port may copy these files.

[tenomoto (Takeshi Enomoto)]

Committed in r94346.