Opened 12 years ago
Closed 12 years ago
#35019 closed update (fixed)
SuiteSparse: update to 4.0.0
| Reported by: | zan@… | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.1.1 |
| Keywords: | haspatch | Cc: | skymoo (Adam Mercer) |
| Port: | SuiteSparse |
Description (last modified by ryandesign (Ryan Carsten Schmidt))
Update SuiteSparse to version 4.0.0. Related ports metis (updated) and scipy (patched).
Solves ticket #32788.
Tested with Apple gcc-4.2, llvm-gcc-4.2, clang, and Macports gcc-4.5 on Snow Leopard 10.6.8, 32/64 bit.
Attachments (3)
Change History (16)
comment:1 Changed 12 years ago by zan@…
comment:2 Changed 12 years ago by skymoo (Adam Mercer)
| Type: | defect → update |
|---|
comment:3 Changed 12 years ago by jmroot (Joshua Root)
| Cc: | jmr@… removed |
|---|
comment:4 follow-up: 5 Changed 12 years ago by skymoo (Adam Mercer)
The patch fails to apply for me, also it contains whitespace changes so it's difficult to see what's changed. Can you attach a series of patches that separates whitespace changes from functional changes?
comment:5 Changed 12 years ago by zan@…
Attached a new diff file. Minimized whitespace changes and stayed closer to style of previous version. Also links to libmetis.dylib instead of libmetis.a (since metis version 5.0.2_1). Removed a few unnecessary changes.
Replying to ram@…:
The patch fails to apply for me, also it contains whitespace changes so it's difficult to see what's changed. Can you attach a series of patches that separates whitespace changes from functional changes?
comment:6 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
| Description: | modified (diff) |
|---|
comment:7 follow-up: 8 Changed 12 years ago by skymoo (Adam Mercer)
Thanks, that almost applies cleanly although there are still a few issues (e.g. you removed epoch which is always bad), I've attached a clean patch that builds for me. Can you confirm that this is correct? If so I'll push this.
Changed 12 years ago by skymoo (Adam Mercer)
| Attachment: | suitespace-4.0.0.diff added |
|---|
comment:8 Changed 12 years ago by zan@…
I thought epoch was only needed for the forced downgrade from 3.7.0 back to 3.4.0, months ago. It needs to stay?
Patch works for me.
Replying to ram@…:
Thanks, that almost applies cleanly although there are still a few issues (e.g. you removed epoch which is always bad), I've attached a clean patch that builds for me. Can you confirm that this is correct? If so I'll push this.
comment:9 Changed 12 years ago by skymoo (Adam Mercer)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Once epoch has been set it can never be removed or decreased.
Pushed in r94989
comment:10 Changed 12 years ago by skymoo (Adam Mercer)
This failed to build on the buildbot. It built on my Lion machine, but not on the Snow Leopard buildbot. As you provided this patch, any ideas?
comment:11 follow-up: 12 Changed 12 years ago by skymoo (Adam Mercer)
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
comment:12 Changed 12 years ago by zan@…
SPQR module uses g++, therefore the dylib needs to be linked using g++. Patch attached.
Changed 12 years ago by zan@…
| Attachment: | Portfile.2.diff added |
|---|
comment:13 Changed 12 years ago by skymoo (Adam Mercer)
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
that should have been type: update, not type: new defect.