New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #35067 (closed defect: fixed)

Opened 11 months ago

Last modified 9 months ago

qt4-mac: macdeployqt thinks frameworks are in a wrong location (+framework variant)

Reported by: frederic.devernay@… Owned by: michaelld@…
Priority: Normal Milestone:
Component: ports Version: 2.1.1
Keywords: haspatch Cc:
Port: qt4-mac

Description

macdeployqt thinks the frameworks are in prefix/Library/lib, whereas they are in prefix/Library/Frameworks. The consequence is that it doesn't change the framework location in the binary, and the app is not standalone.

The fix is very simple (patch attached)

Attachments

patch-tools_macdeployqt_shared_shared.cpp.diff (614 bytes) - added by frederic.devernay@… 11 months ago.

Change History

Changed 11 months ago by frederic.devernay@…

comment:1 Changed 11 months ago by ryandesign@…

  • Owner changed from macports-tickets@… to michaelld@…
  • Keywords haspatch added

comment:2 Changed 11 months ago by michaelld@…

Hmm ... I wonder if there's a way to distinguish between a LIBRARY path and FRAMEWORK path, such as what I set up with the new qt4-mac? I'd much prefer to be able to switch between them depending on how Qt is installed, rather than hard-coding the search path depending on how Qt is installed. I'll take a look at the code that you patched to see what's up with it.

comment:3 Changed 11 months ago by frederic.devernay@…

the single line affected by the patch actually only affects Qt libraries that appear in the "otool -L ..." output as "*.framework", whereas libraries installed by the non-framework version appear as "*.dylib", so the patch shouldn't break the non-framework version

comment:4 Changed 9 months ago by michaelld@…

This patch looks good to me; as you say, the code already distinguishes between library and framework, and this one impacts frameworks only. So, I'll get it into the next set of changes to qt4-mac. Thanks & sorry it took me so long to get here.

comment:5 Changed 9 months ago by michaelld@…

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in r96896.

Note: See TracTickets for help on using tickets.