Ticket #35549 (closed defect: fixed)
pinfo: update to 0.6.10
| Reported by: | ryandesign@… | Owned by: | master@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.1.2 |
| Keywords: | haspatch | Cc: | |
| Port: | pinfo |
Description
This patch updates pinfo to 0.6.10. It also switches to a bz2 distfile and fixes the livecheck. 0.6.10 doesn't include configure script, so autoconf used. The clang compiler is blacklisted (fixing #35546). It also adds dependencies on ncurses and readline (fixing #35547) and adds a dependency on gettext and enables gettext support (I didn't see a reason why it was disabled). It changes the reinplace into a patchfile since that's more future-proof, and puts the MacPorts path first in the list, not last.
The whitespace of my changes does not follow the existing whitespace of this Portfile. Instead, it follows our recommended whitespace style of four spaces per indent (instead of using tabs). In a subsequent commit, I would like to fix the remaining lines of the Portfile to conform to this whitespace style, and add our standard modeline to indicate this.
Please let me know if these changes are okay to commit.
Attachments
Change History
comment:1 follow-up: ↓ 3 Changed 10 months ago by master@…
The changes look OK. Please, commit.
Are you sure 6.10 does not compile with clang on 10.8? It compiled with configure.compiler clang on 10.7.
Consider using the patches I collected from debian that fix
- typos in docs (like it's -> its conversion, hey, feels like we take part in a crusade ;)
- case, when file name starts with "dir" but is not "dir"
- additional check that a file has been opened before closing it. I do not know what setup triggers that bug, but the change looks harmless in any case.
comment:2 Changed 10 months ago by ryandesign@…
- Status changed from new to closed
- Resolution set to fixed
Committed my diff and your debian patches in r96281. I also indicated the port's license and added configure.args to specify the location of readline and ncurses. If upstream is not already aware of these debian patches you should make them aware, so that they can include them in the next official version of pinfo.
comment:3 in reply to: ↑ 1 Changed 10 months ago by ryandesign@…
Oh, and:
Replying to master@…:
Are you sure 6.10 does not compile with clang on 10.8? It compiled with configure.compiler clang on 10.7.
Yes, 0.6.10 fails in the same way on 10.8 with Xcode 4.4 as 0.6.9 did, as documented in #35546. Since you say it worked on 10.7 with a presumably older version of Xcode, I blacklisted clang only for Xcode 4.4 and up. Ideally we (or rather, the developer of pinfo) should fix it so it can compile with Xcode 4.4's clang.