netatalk: fatal error: 'netat/appletalk.h' file not found

[benedikt.hielscher@…]

I tried to install netatalk, but I always get this error message:

:error:build org.macports.build for port netatalk returned: command execution failed
:debug:build Error code: CHILDSTATUS 14388 2
:debug:build Backtrace: command execution failed
    while executing
"system -nice 0 $fullcmdstring"
    ("eval" body line 1)
    invoked from within
"eval system $notty $nice \$fullcmdstring"
    invoked from within
"command_exec build"
    (procedure "portbuild::build_main" line 8)
    invoked from within
"$procedure $targetname"

[benedikt.hielscher@…]

logfile

[benedikt.hielscher@…]

Sorry, forgot to mention the following: Xcode version is 4.5.1, I'm using OS X 10.8.2 Mountain Lion

[ryandesign (Ryan Carsten Schmidt)]

Your log was not from a clean build attempt, but I can reproduce the problem on my system so I'm attaching my log which is from a clean attempt.

The problem is the port wants to include appletalk.h but that doesn't exist anymore. This was ​reported on IRC about Lion as well. This had previously been reported about Snow Leopard in #21159. AppleTalk doesn't exist in Snow Leopard and up so r57161 disabled the port completely on Snow Leopard and up. r60660 changed it to offer a "noat" variant to disable AppleTalk, and then included a block to do the same unconditionally on Snow Leopard only.

Variant names should not begin with "no", and code should not be duplicated. The best solution is to have an "appletalk" variant, make it on by default on Leopard and below, and ensure that it cannot be enabled on Snow Leopard and above.

[ryandesign (Ryan Carsten Schmidt)]

I'm attaching a patch to make these changes. It still doesn't build though. Maybe updating the port would help.

We should also ask ourselves why we want to give the user the choice to disable AppleTalk on supported systems in the first place. #22529 caused the "noat" variant to be added but does not explain why. It would be simpler if the port would enable or disable AppleTalk as appropriate for the OS X version and not give the user a choice.

[cooljeanius (Eric Gallager)]

Cc Me!

[jmroot (Joshua Root)]

r133417 (maintainer timeout)