Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#38193 closed defect (fixed)

stellarium: remove unused code

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: raimue (Rainer Müller)
Priority: Normal Milestone:
Component: ports Version: 2.1.3
Keywords: Cc: michaelld (Michael Dickens)
Port: stellarium

Description

In the stellarium portfile, these lines don't appear to be doing anything and could be removed:

    # Determine which archs to build
    if {[variant_isset universal]} {
        set archs ${configure.universal_archs}
    } else {
        set archs ${configure.build_arch}
    }
    reinplace "s:SET(CMAKE_OSX_ARCHITECTURES \"i386;ppc\"):SET(CMAKE_OSX_ARCHITECTURES \"${archs}\"):" ${worksrcpath}/CMakeLists.txt
platform darwin 9 {
    # Upgrade MacOSX SDK version to 10.5, for compatibility with qt4-mac
    post-patch {
        reinplace "s:-mmacosx-version-min=10.4:-mmacosx-version-min=10.5:" ${worksrcpath}/CMakeLists.txt
        reinplace "s:SET(CMAKE_OSX_DEPLOYMENT_TARGET \"10.4\"):SET(CMAKE_OSX_DEPLOYMENT_TARGET \"10.5\"):" ${worksrcpath}/CMakeLists.txt
        reinplace "s:MacOSX10.4u.sdk:MacOSX10.5.sdk:" ${worksrcpath}/CMakeLists.txt
    }
}
platform darwin 10 {
    # Upgrade MacOSX SDK version to 10.6, for compatibility with qt4-mac
    post-patch {
        reinplace "s:-mmacosx-version-min=10.4:-mmacosx-version-min=10.6:" ${worksrcpath}/CMakeLists.txt
        reinplace "s:SET(CMAKE_OSX_DEPLOYMENT_TARGET \"10.4\"):SET(CMAKE_OSX_DEPLOYMENT_TARGET \"10.6\"):" ${worksrcpath}/CMakeLists.txt
        reinplace "s:MacOSX10.4u.sdk:MacOSX10.6.sdk:" ${worksrcpath}/CMakeLists.txt
    }
}

Change History (2)

comment:1 Changed 11 years ago by raimue (Rainer Müller)

Resolution: fixed
Status: newclosed

Thanks for the report! The first of these actually broke the +universal variant...

Fixed in r103432.

comment:2 in reply to:  1 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Replying to raimue@…:

Thanks for the report! The first of these actually broke the +universal variant...

That's what I would have thought as well, but it didn't seem to be the case. I didn't investigate further.

Note: See TracTickets for help on using tickets.