#38272 closed defect (fixed)
ostinato @0.5.1 needs --disable-dependency-tracking removed from its configure.universal_args
| Reported by: | cooljeanius (Eric Gallager) | Owned by: | g5pw (Aljaž Srebrnič) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.1.3 |
| Keywords: | haspatch | Cc: | michaelld (Michael Dickens) |
| Port: | ostinato |
Description
qmake doesn't recognize the option. (Perhaps this could be done in the qt4 portgroup? That's an issue for another ticket though). Anyway I've attached a diff for Ostinato's portfile fixing this issue. I also took this opportunity to silence a port lint warning by adding a license.
Attachments (1)
Change History (8)
Changed 11 years ago by cooljeanius (Eric Gallager)
| Attachment: | Ostinato-Portfile.diff added |
|---|
comment:1 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)
| Cc: | michaelld@… added; g5pw@… removed |
|---|---|
| Owner: | changed from macports-tickets@… to g5pw@… |
I think not all ports that use the qt4 portgroup use the qmake configuration system, so adding this command unconditionally to the qt4 portgroup would not be correct. However, it might be nice to either have a qmake portgroup or an option in the qt4 portgroup that indicates qmake is to be used that could add this command.
comment:2 follow-up: 4 Changed 11 years ago by g5pw (Aljaž Srebrnič)
Looks good to me, thanks! commited in r103664.
comment:3 follow-up: 6 Changed 11 years ago by michaelld (Michael Dickens)
Making a qmake portgroup could do this. I don't have time for it right now, but if someone else does then I say go for it!
comment:4 Changed 11 years ago by cooljeanius (Eric Gallager)
comment:5 Changed 11 years ago by g5pw (Aljaž Srebrnič)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Yup, I was sure I closed it before!
comment:6 Changed 11 years ago by cooljeanius (Eric Gallager)
Replying to michaelld@…:
Replying to ryandesign@…:
I think not all ports that use the qt4 portgroup use the qmake configuration system, so adding this command unconditionally to the qt4 portgroup would not be correct. However, it might be nice to either have a qmake portgroup or an option in the qt4 portgroup that indicates qmake is to be used that could add this command.
Making a qmake portgroup could do this. I don't have time for it right now, but if someone else does then I say go for it!
Made a new issue for a qmake portgroup: #38280
Edit: that's closed as of r106912 now, so now this port can use it.
comment:7 Changed 11 years ago by cooljeanius (Eric Gallager)
Somehow I left out ostinato from #39424 but it could have been included in that ticket, too...
diff to apply to Ostinato's portfile