Changes between Version 38 and Version 39 of Ticket #38582, comment 6


Ignore:
Timestamp:
Aug 7, 2013, 2:38:15 PM (11 years ago)
Author:
cooljeanius (Eric Gallager)
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #38582, comment 6

    v38 v39  
    4141|| `AC_TYPE_MODE_T` || `src/darwintracelib1.0/darwintrace.c:963` || `mode_t mode;` || used in wrapper for the `open` function || `/* wrapper for open(2) preventing opening files outside the sandbox */` Since it uses the `mode_t` type in it, this should be checked for ||
    4242|| `AC_TYPE_OFF_T` || `src/pextlib1.0/flock.c:57` || `off_t curpos;` || in an `ifdef`: `#if defined(HAVE_LOCKF) && !defined(HAVE_FLOCK)` || It wouldn't be too much more to ask to add another condition to this `#if`: just a simple `&& defined(HAVE_OFF_T)` would do ||
    43 || `AC_TYPE_PID_T` || `src/darwintracelib1.0/darwintrace.c:134` || `static pid_t __darwintrace_pid = (pid_t) - 1;` || global variable? || `darwintrace` (and `daemondo`, too, for that matter) uses `pid`s extensively; check to see how they work ||
     43|| `AC_TYPE_PID_T` || `src/darwintracelib1.0/darwintrace.c:134` || `static pid_t __darwintrace_pid = (pid_t) - 1;` || function prototype? || `darwintrace` (and `daemondo`, too, for that matter) uses `pid`s extensively; check to see how they work ||
    4444|| `AC_TYPE_SIZE_T` || `src/cregistry/entry.c:376` || `size_t query_len, query_space;` || variable type || supplements the `MP_CHECK_READLINK_IS_P1003_1A` macro, which defines the variable "`READLINK_IS_NOT_P1003_1A`" to 1 "`if readlink does not conform with POSIX 1003.1a (where third argument is a size_t and return value is a ssize_t)`". Heck, instead of putting this in the main `configure.ac` file, you could just `AC_REQUIRE` it from your definition for your `MP_CHECK_READLINK_IS_P1003_1A` macro... ||
    4545|| `AC_TYPE_SSIZE_T` || `src/darwintracelib1.0/darwintrace.c:996` || `ssize_t readlink(const char *path, char *buf, size_t bufsiz) {` || variable type (used conditionally) || see note for the `AC_TYPE_SIZE_T` macro above ||
    4646|| `AC_TYPE_UID_T` || `src/pextlib1.0/Pextlib.c:465` || `if (lchown(path, (uid_t) user, (gid_t) group) != 0) {` || condition || good to check for user id types ||
    47 || `AC_TYPE_UINT32_T` || `src/darwintracelib1.0/darwintrace.c:126` || `static char *__send(const char *buf, uint32_t len, int answer);` || looks like another global variable definition... || Might want to `AC_CHECK_SIZEOF` it as well, in addition to checking for its existence... ||
     47|| `AC_TYPE_UINT32_T` || `src/darwintracelib1.0/darwintrace.c:126` || `static char *__send(const char *buf, uint32_t len, int answer);` || looks like another function prototype definition... || Might want to `AC_CHECK_SIZEOF` it as well, in addition to checking for its existence... ||
    4848|| `AC_TYPE_UINT8_T` || `src/machista1.0/libmachista.c:87` || `if ((((uint8_t *) address) - ((uint8_t *) input->data)) + length > input->length) {` || condition || See above ||
    4949