Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#38657 closed defect (fixed)

gnome-vfs @2.24.4 build failure: unknown type name 'GStaticRecMutex'

Reported by: caustindavis@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.1.3
Keywords: Cc: ryandesign (Ryan Carsten Schmidt), jdgleeson, cooljeanius (Eric Gallager), mas@…, Ionic (Mihai Moldovan)
Port: gnome-vfs

Description

I attempted to install wine but encountered the following error

--->  Building gnome-vfs
Error: org.macports.build for port gnome-vfs returned: command execution failed

The log file for port gnome-vfs ends with

:info:build gnome-vfs-async-job-map.c:30:8: error: unknown type name 'GStaticRecMutex'
:info:build static GStaticRecMutex async_job_map_lock = G_STATIC_REC_MUTEX_INIT;
:info:build        ^
:info:build gnome-vfs-async-job-map.c:30:45: error: use of undeclared identifier 'G_STATIC_REC_MUTEX_INIT'
:info:build static GStaticRecMutex async_job_map_lock = G_STATIC_REC_MUTEX_INIT;
:info:build                                             ^
:info:build gnome-vfs-async-job-map.c:37:8: error: unknown type name 'GStaticMutex'
:info:build static GStaticMutex async_job_callback_map_lock = G_STATIC_MUTEX_INIT;
:info:build        ^
:info:build gnome-vfs-async-job-map.c:37:51: error: use of undeclared identifier 'G_STATIC_MUTEX_INIT'
:info:build static GStaticMutex async_job_callback_map_lock = G_STATIC_MUTEX_INIT;
:info:build                                                   ^
:info:build gnome-vfs-async-job-map.c:164:2: warning: implicit declaration of function 'g_static_rec_mutex_lock' is invalid in C99 [-Wimplicit-function-declaration]
:info:build         g_static_rec_mutex_lock (&async_job_map_lock);
:info:build         ^
:info:build gnome-vfs-async-job-map.c:172:2: warning: implicit declaration of function 'g_static_rec_mutex_unlock' is invalid in C99 [-Wimplicit-function-declaration]
:info:build         g_static_rec_mutex_unlock (&async_job_map_lock);
:info:build         ^
:info:build gnome-vfs-async-job-map.c:188:2: warning: implicit declaration of function 'g_static_mutex_lock' is invalid in C99 [-Wimplicit-function-declaration]
:info:build         g_static_mutex_lock (&async_job_callback_map_lock);
:info:build         ^
:info:build gnome-vfs-async-job-map.c:202:2: warning: implicit declaration of function 'g_static_mutex_unlock' is invalid in C99 [-Wimplicit-function-declaration]
:info:build         g_static_mutex_unlock (&async_job_callback_map_lock);
:info:build         ^
:info:build 4 warnings and 4 errors generated.
:info:build make[3]: *** [gnome-vfs-async-job-map.lo] Error 1
:info:build make[3]: *** Waiting for unfinished jobs....
:info:build libtool: compile:  /usr/bin/clang -DHAVE_CONFIG_H -I. -I.. -I.. -I.. -D_REENTRANT -DORBIT2=1 -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include -I/opt/local/include/gconf/2 -I/opt/local/include/orbit-2.0 -I/opt/local/include/dbus-1.0 -I/opt/local/lib/dbus-1.0/include -I/opt/local/include/libxml2 -I/opt/local/include -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include -DXDG_PREFIX=_gnome_vfs_xdg -DDBUS_API_SUBJECT_TO_CHANGE -D_FILE_OFFSET_BITS=64 -D_BSD_SOURCE -D_LARGEFILE64_SOURCE -D_POSIX_PTHREAD_SEMANTICS -D_REENTRANT -DG_DISABLE_DEPRECATED -DGNOME_VFS_PREFIX=\"/opt/local\" -DGNOME_VFS_BINDIR=\"/opt/local/bin\" -DGNOME_VFS_DATADIR=\"/opt/local/share\" -DGNOME_VFS_LIBDIR=\"/opt/local/lib\" -DGNOME_VFS_LOCALEDIR=\"/opt/local/share/locale\" -DGNOME_VFS_SYSCONFDIR=\"/opt/local/etc\" -DG_LOG_DOMAIN=\"libgnomevfs\" -I/opt/local/include -pipe -O2 -arch x86_64 -c gnome-vfs-cancellable-ops.c -o gnome-vfs-cancellable-ops.o >/dev/null 2>&1
:info:build libtool: compile:  /usr/bin/clang -DHAVE_CONFIG_H -I. -I.. -I.. -I.. -D_REENTRANT -DORBIT2=1 -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include -I/opt/local/include/gconf/2 -I/opt/local/include/orbit-2.0 -I/opt/local/include/dbus-1.0 -I/opt/local/lib/dbus-1.0/include -I/opt/local/include/libxml2 -I/opt/local/include -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include -DXDG_PREFIX=_gnome_vfs_xdg -DDBUS_API_SUBJECT_TO_CHANGE -D_FILE_OFFSET_BITS=64 -D_BSD_SOURCE -D_LARGEFILE64_SOURCE -D_POSIX_PTHREAD_SEMANTICS -D_REENTRANT -DG_DISABLE_DEPRECATED -DGNOME_VFS_PREFIX=\"/opt/local\" -DGNOME_VFS_BINDIR=\"/opt/local/bin\" -DGNOME_VFS_DATADIR=\"/opt/local/share\" -DGNOME_VFS_LIBDIR=\"/opt/local/lib\" -DGNOME_VFS_LOCALEDIR=\"/opt/local/share/locale\" -DGNOME_VFS_SYSCONFDIR=\"/opt/local/etc\" -DG_LOG_DOMAIN=\"libgnomevfs\" -I/opt/local/include -pipe -O2 -arch x86_64 -c gnome-vfs-async-ops.c -o gnome-vfs-async-ops.o >/dev/null 2>&1
:info:build make[3]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_gnome_gnome-vfs/gnome-vfs/work/gnome-vfs-2.24.4-x86_64/libgnomevfs'
:info:build make[2]: *** [all] Error 2
:info:build make[2]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_gnome_gnome-vfs/gnome-vfs/work/gnome-vfs-2.24.4-x86_64/libgnomevfs'
:info:build make[1]: *** [all-recursive] Error 1
:info:build make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_gnome_gnome-vfs/gnome-vfs/work/gnome-vfs-2.24.4-x86_64'
:info:build make: *** [all] Error 2
:info:build make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_gnome_gnome-vfs/gnome-vfs/work/gnome-vfs-2.24.4-x86_64'
:info:build Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_gnome_gnome-vfs/gnome-vfs/work/gnome-vfs-2.24.4-x86_64" && /usr/bin/make -j4 -w all 
:info:build Exit code: 2
:error:build org.macports.build for port gnome-vfs returned: command execution failed
:debug:build Error code: NONE
:debug:build Backtrace: command execution failed
    while executing
"$procedure $targetname"
:info:build Warning: targets not executed for gnome-vfs: org.macports.activate org.macports.build org.macports.destroot org.macports.install
:notice:build Please see the log file for port gnome-vfs for details:
    /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_gnome_gnome-vfs/gnome-vfs/main.log

I'm running OS X 10.7.5 with Xcode 4.6.1. I turned to wine because I need to use an older Windows application but I confess I'm at the edge of my technical know-how. Please help?

Attachments (3)

main.log (234.2 KB) - added by caustindavis@… 11 years ago.
Log file for port gnome-vfs
main.2.log (118.7 KB) - added by toropezzato@… 11 years ago.
patch-port-glib2-2.6.31-and-up.diff (23.3 KB) - added by Ionic (Mihai Moldovan) 11 years ago.
Changes required to remove deprecated glib2 functionality in gnome-vfs

Download all attachments as: .zip

Change History (16)

Changed 11 years ago by caustindavis@…

Attachment: main.log added

Log file for port gnome-vfs

comment:1 Changed 11 years ago by jmroot (Joshua Root)

Summary: gnome-vfs 2.24.4: command execution failedgnome-vfs @2.24.4 build failure: unknown type name 'GStaticRecMutex'

comment:2 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign@… added

Cc Me!

comment:3 Changed 11 years ago by toropezzato@…

I'm having the same issue, if the recent change to the gnome-vfs portfile was supposed to fix this.

Changed 11 years ago by toropezzato@…

Attachment: main.2.log added

comment:4 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

The recent change to the portfile, r104859, was only meant to fix the livecheck.

comment:5 Changed 11 years ago by jdgleeson

Cc: jdgleeson@… added

Cc Me!

comment:6 Changed 11 years ago by ajdudman

While we wait for an approved API solution from someone with the time to write one, why not at least use the deprecated API so the port will build? Other ports depend on this one. Personally, I have done this in my Portfile:

configure.cflags-append     -UG_DISABLE_DEPRECATED

Last edited 11 years ago by ajdudman (previous) (diff)

comment:7 Changed 11 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

comment:8 Changed 11 years ago by mas@…

Cc: mas@… added

Cc Me!

comment:9 Changed 11 years ago by Ionic (Mihai Moldovan)

gnome-vfs doesn't build anymore due to previously deprecated and as of (at least) glib2 v. 2.36 (also glib2-devel which is at 2.37 currently) removed functions and types.

I haven't seen any patch either.

Also, gnome-vfs is deprecated anyway, replaced by gvfs and gio. Can't we make ports depending on gnome-vfs like gstreamer010-gst-plugins-base (and others) depend on gvfs && gio and compile with those two instead? Do they even really need gnome-vfs?

Rewriting gnome-vfs to work with glib2 and glib2-devel just isn't worth the effort, as only a few packages are depending on it nowadays.

comment:10 Changed 11 years ago by Ionic (Mihai Moldovan)

Cc: ionic@… added

Cc Me!

comment:11 Changed 11 years ago by Ionic (Mihai Moldovan)

gstreamer010-gst-plugins-base has a no_gnome_vfs variant, we should remove this and unconditionally build without gnome-vfs support.

gtksourceview, libgnome, libgtkhtml, thunderbird-x11, qalculate-gtk, p5-gnome2-vfs, py25-gnome, py26-gnome, py27-gnome, rb-gnomevfs, firefox-x11, firefox-x11-devel depend unconditionally on gnome-vfs.

If we remove gnome-vfs, we can also get rid of p5-gnome2-vfs and rb-gnomevfs.

libgtkhtml only uses gnome-vfs for the testcases/testgtkhtml, given that we don't run that anyway, we can get rid of the gnome-vfs dependency.

Regarding thunderbird-x11, firefox-x11 and firefox-x11-devel, those ports are *heavily* outdated and a potential security risk. Do we have users for those? If not, I'd get rid of them as well.

I can't find dependencies for gnome-vfs on Gentoo for gtksourceview, qalculate-gtk, instead both are depending on libgnome. We may want to change the dependencies from gnome-vfs to libgnome as well.

This leaves us with libgnome, py25-gnome, py26-gnome and py27-gnome with hard dependencies on gnome-vfs. That's an issue, as we can't just remove or change those ports, especially not libgnome. :(

Does anybody else have some idea?

comment:12 Changed 11 years ago by jmroot (Joshua Root)

Resolution: fixed
Status: newclosed

Should build after r105824.

Changed 11 years ago by Ionic (Mihai Moldovan)

Changes required to remove deprecated glib2 functionality in gnome-vfs

comment:13 Changed 11 years ago by Ionic (Mihai Moldovan)

Should you want to disable the deprecated stuff again, gnome-vfs is compiling with my above patch. No warranty though, especially for the G(Static)Private init which may be wrong.

Note: See TracTickets for help on using tickets.