HPGS @1.1.8

[potmj (Michael Pot)]

Easy HPGS installation for macports users

My first Portfile creation & submission

Developed on 10.5.8

[potmj (Michael Pot)]

First Portfile for HPGS

[ryandesign (Ryan Carsten Schmidt)]

Thanks. Some observations:

• The license should be indicated.
• MacPorts does follow HTTP redirects when downloading.
• To download from sourceforge, use the sourceforge fetch group rather than hardcoding one specific sourceforge server.
• Why are you setting the worksrcdir in a pre-build block instead of globally? Doesn't that cause destroot to fail if you run it separately from build? (i.e. "sudo port build && sudo port destroot")
• When you disable the configure phase you're responsible for adding a universal variant and ensuring that the port is UsingTheRightCompiler and -arch flags.
• "distname ${name}-${version}" is the default so you don't need to list that.

[cooljeanius (Eric Gallager)]

Also the proper way to obfuscate your email address is like this:

 actrix.co.nz:fmw

[potmj (Michael Pot)]

Replying to ryandesign@…: Dear Ryan
Sorry, this submission was not meant to go out - I thought I stopped the submission when I found some problems while attaching the files (Patch file naming etc).
I logged out without pushing the submit button, so not sure what happened!!!
I ran out of time, so will have another go in a day or so , and try & fix some of the things you have mentioned (I don't understand how to deal with them all - fetch group & configure).
Many thanks
Michael

[ryandesign (Ryan Carsten Schmidt)]

revised portfile proposal

[ryandesign (Ryan Carsten Schmidt)]

I've attached a revised portfile, with these changes:

• indicated license LGPL-2.1+
• used sourceforge fetch group
• set build.dir instead of conditionally setting worksrcdir in the build phase
• set correct -arch flags and optimization flags and ensure UsingTheRightCompiler
• removed unnecessary distname directive
• fixed obfuscation of maintainer email address
• reformatted description and fixed whitespace to conform to modeline

Since I don't have the patchfiles referenced I can't see if it builds properly or work on adding a universal variant, though doing so could be as simple as adding the line "variant universal {}" before the first invocation of the get_canonical_archflags proc. I'm not sure what the Makefile patch does; maybe it's unnecessary with the correct build.args passed in from the Portfile. I can guess that the hpgsimage.c patch will make it compatible with libpng 1.4 and later.

[potmj (Michael Pot)]

Updated working Portfile

[potmj (Michael Pot)]

prefix fix from Fink to Macports

[potmj (Michael Pot)]

Lib version patch

[potmj (Michael Pot)]

gcc flags conflict fix for dependent generation

[potmj (Michael Pot)]

Many thanks for doing all that - it has pointed me in the right direction - I hope.
I have used your Portfile.2 and adjusted it so it now builds on intel 10.5.8 with gcc 4.2, > file reports:
/opt/local/bin/hpgs: Mach-O fat file with 2 architectures: [ : Mach-O ppc_7400 executable ] [ I386: Mach-O i386 executable ]

It might be possible to eliminate the Makefile patch with some changes in the Portfile build.args
The patch adjusts a prefix variable at the start

Yes the hpgsimage.c patch makes it do libpng15. I couldn't find a way of making it do something like libpng >= 1.5 and making it work with the Portfile depends_lib section.

There is an additional include.mak patch to cope with a flags conflict, and again, there may be better ways to handel that, but I think it is at least working correctly.