Opened 11 years ago

Closed 2 years ago

Last modified 2 years ago

#40125 closed defect (fixed)

grok: error: non-void function 'grok_predicate_regexp_init' should return a value [-Wreturn-type]

Reported by: KurtPfeifle (Kurt Pfeifle) Owned by:
Priority: Normal Milestone:
Component: ports Version: 2.2.0
Keywords: Cc: ryandesign (Ryan Carsten Schmidt), chrstphrchvz (Christopher Chavez)
Port: grok

Description

My attempt to run 'port -p upgrade grok' failed. The following lines are in the log:

cc -c -I/opt/local/include -I/opt/local/include/db46 conf.tab.c -o conf.tab.o
In file included from conf.y:5:
conf.tab.h:112:21: warning: declaration of 'struct config' will not be visible outside of this function [-Wvisibility]
int yyparse (struct config *conf);
                    ^
predicates.c:108:5: error: non-void function 'grok_predicate_regexp_init' should return a value [-Wreturn-type]
    return;
    ^
predicates.c:132:5: error: non-void function 'grok_predicate_regexp_init' should return a value [-Wreturn-type]
    return;
    ^
2 errors generated.
gnumake: *** [predicates.o] Error 1

Attachments (1)

main.log (6.2 KB) - added by KurtPfeifle (Kurt Pfeifle) 11 years ago.
main.log for failed upgrade of grok

Download all attachments as: .zip

Change History (9)

Changed 11 years ago by KurtPfeifle (Kurt Pfeifle)

Attachment: main.log added

main.log for failed upgrade of grok

comment:1 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign@… added
Owner: changed from macports-tickets@… to jim@…
Port: grok added
Summary: 'grok' does not buildgrok: error: non-void function 'grok_predicate_regexp_init' should return a value [-Wreturn-type]

Remember to fill in the Port field and to Cc that port's maintainer.

This is a common problem when using clang, because clang is pickier about programming errors like this.

Ordinarily you could fix it by blacklisting clang, however this port is not UsingTheRightCompiler so that won't help.

We should fix these problems but possibly a newer version of grok has already corrected these errors.

comment:2 in reply to:  1 ; Changed 11 years ago by KurtPfeifle (Kurt Pfeifle)

Replying to ryandesign@…:

Remember to fill in the Port field and to Cc that port's maintainer.

Mea culpa! I forgot to fill in the Port field... Sorry!

However,

(a) I don't see a Cc field for the port's maintainer and

(b) couldn't you do this on the web interface automatically for whenever the port field *IS* filled in?

comment:3 in reply to:  2 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Replying to kurt.pfeifle@…:

(a) I don't see a Cc field for the port's maintainer and

It might not be shown to non project members except on the new ticket form, I'm not sure.

(b) couldn't you do this on the web interface automatically for whenever the port field *IS* filled in?

That would involve writing a Trac plugin to somehow integrate it with our ports database. Nobody has thus far investigated how this might be accomplished.

comment:4 Changed 5 years ago by chrstphrchvz (Christopher Chavez)

Port was set to nomaintainer in 2013.

comment:5 Changed 5 years ago by chrstphrchvz (Christopher Chavez)

Cc: chrstphrchvz added

comment:6 Changed 5 years ago by mf2k (Frank Schima)

Owner: jim@… deleted
Status: newassigned

comment:7 in reply to:  1 Changed 2 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: assignedclosed

Replying to ryandesign:

possibly a newer version of grok has already corrected these errors.

It was fixed in https://github.com/jordansissel/grok/commit/2f406335085205204d8f57fc677338ba53bebf50 which was shipped in 1.20110308.1.

comment:8 in reply to:  1 Changed 2 years ago by ryandesign (Ryan Carsten Schmidt)

Note: See TracTickets for help on using tickets.