Opened 11 years ago

Closed 9 years ago

#40182 closed defect (fixed)

atlas: wrong param -dynamicliblib

Reported by: alex.caldas@… Owned by: Veence (Vincent)
Priority: Normal Milestone:
Component: ports Version: 2.2.0
Keywords: haspatch Cc: ryandesign (Ryan Carsten Schmidt), seanfarley (Sean Farley)
Port: atlas

Description

Hi.

Trying to install the atlas using the macports i receive the error

info:build cd RCW_tMp ; /opt/local/bin/clang-mp-3.3 -O3 -fomit-frame-pointer -fPIC -march=native -mavx  -dynamicliblib -o ../libsatlas.dylib \
:info:build         -install_name /opt/local/lib/libsatlas.dylib -current_version 3.10.1 \
:info:build         -compatibility_version 3.10.1 *.o -lpthread -lm /opt/local/lib/gcc48/libgfortran.dylib
:info:build clang: error: invalid argument '-compatibility_version 3.10.1' only allowed with '-dynamiclib'
:info:build make[1]: *** [dylib] Error 1
:info:build make: *** [shared_all] Error 2
:info:build Command failed: /usr/bin/make shared_all

As you can see the parameter is dynamicliblib and not dynamiclib

Attachments (2)

atlas.diff (1.2 KB) - added by ryandesign (Ryan Carsten Schmidt) 10 years ago.
proposed patch
patch-makes-Make.lib.diff (2.5 KB) - added by ryandesign (Ryan Carsten Schmidt) 10 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: changed from macports-tickets@… to vince@…
Port: atlas added

comment:2 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign@… sean@… added
Keywords: haspatch added
Summary: Atlas wrong param dynamicliblibatlas: wrong param -dynamicliblib

I think this happened because you interrupted the build (or the build ended with an error), then tried again without cleaning? It's impossible to know because you didn't attach the main.log file.

Sean committed a change in r113780 that I think was meant to address this, but I don't think it was correct. I think a better fix would be to remove the reinplaces and use a normal patchfile to fix these bugs in makes/Make.lib directly. The attached patch is untested because atlas takes so long to build.

Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: atlas.diff added

proposed patch

Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: patch-makes-Make.lib.diff added

comment:3 in reply to:  2 Changed 10 years ago by seanfarley (Sean Farley)

Replying to ryandesign@…:

I think this happened because you interrupted the build (or the build ended with an error), then tried again without cleaning? It's impossible to know because you didn't attach the main.log file.

Sean committed a change in r113780 that I think was meant to address this, but I don't think it was correct. I think a better fix would be to remove the reinplaces and use a normal patchfile to fix these bugs in makes/Make.lib directly. The attached patch is untested because atlas takes so long to build.

I fixed my broken attempt in r113831. The patch file is probably better since it could be used to clean up the portfile but I'll defer to Vince on that one.

comment:4 Changed 10 years ago by Veence (Vincent)

Sorry, I was really swamped up to now. I'm going to have a look at that, and catch up with other tickets too.

comment:5 Changed 10 years ago by Veence (Vincent)

I have committed the new patch file and the according modifications to the Portfile in r114017. I hope it works

comment:6 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

Thanks. Don't forget to send the patch to the developer too, so they can include it in the next version.

comment:7 Changed 9 years ago by Veence (Vincent)

Resolution: fixed
Status: newclosed

Closing this, forgot to do it.

Note: See TracTickets for help on using tickets.