FileZilla: re-check dependencies

[ryandesign (Ryan Carsten Schmidt)]

FileZilla declares a dependency on libgcrypt:

$ port -v installed FileZilla
The following ports are currently installed:
  FileZilla @3.8.1_2+universal+wxwidgets30 (active) platform='darwin 13' archs='i386 x86_64'
$ port deps FileZilla
Full Name: FileZilla @3.8.1_2+universal+wxwidgets30
Build Dependencies:   pkgconfig
Library Dependencies: dbus, gettext, gmp, gnutls, libgpg-error, libgcrypt, libiconv, libidn, nettle,
                      sqlite3, xdg-utils, wxWidgets-3.0

But it doesn't appear to actually link with libgcrypt:

$ otool -L /Applications/MacPorts/FileZilla.app/Contents/MacOS/filezilla
/Applications/MacPorts/FileZilla.app/Contents/MacOS/filezilla:
	/opt/local/lib/libgnutls.28.dylib (compatibility version 67.0.0, current version 67.0.0)
	/System/Library/Frameworks/IOKit.framework/Versions/A/IOKit (compatibility version 1.0.0, current version 275.0.0)
	/System/Library/Frameworks/Carbon.framework/Versions/A/Carbon (compatibility version 2.0.0, current version 157.0.0)
	/System/Library/Frameworks/Cocoa.framework/Versions/A/Cocoa (compatibility version 1.0.0, current version 20.0.0)
	/System/Library/Frameworks/AudioToolbox.framework/Versions/A/AudioToolbox (compatibility version 1.0.0, current version 492.0.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1197.1.1)
	/System/Library/Frameworks/OpenGL.framework/Versions/A/OpenGL (compatibility version 1.0.0, current version 1.0.0)
	/opt/local/Library/Frameworks/wxWidgets.framework/Versions/wxWidgets/3.0/lib/libwx_osx_cocoau_aui-3.0.dylib (compatibility version 2.0.0, current version 2.0.0)
	/opt/local/Library/Frameworks/wxWidgets.framework/Versions/wxWidgets/3.0/lib/libwx_osx_cocoau_xrc-3.0.dylib (compatibility version 2.0.0, current version 2.0.0)
	/opt/local/Library/Frameworks/wxWidgets.framework/Versions/wxWidgets/3.0/lib/libwx_osx_cocoau_adv-3.0.dylib (compatibility version 2.0.0, current version 2.0.0)
	/opt/local/Library/Frameworks/wxWidgets.framework/Versions/wxWidgets/3.0/lib/libwx_osx_cocoau_core-3.0.dylib (compatibility version 2.0.0, current version 2.0.0)
	/opt/local/Library/Frameworks/wxWidgets.framework/Versions/wxWidgets/3.0/lib/libwx_baseu_xml-3.0.dylib (compatibility version 2.0.0, current version 2.0.0)
	/opt/local/Library/Frameworks/wxWidgets.framework/Versions/wxWidgets/3.0/lib/libwx_baseu_net-3.0.dylib (compatibility version 2.0.0, current version 2.0.0)
	/opt/local/Library/Frameworks/wxWidgets.framework/Versions/wxWidgets/3.0/lib/libwx_baseu-3.0.dylib (compatibility version 2.0.0, current version 2.0.0)
	/opt/local/lib/libidn.11.dylib (compatibility version 18.0.0, current version 18.9.0)
	/opt/local/lib/libsqlite3.0.dylib (compatibility version 9.0.0, current version 9.6.0)
	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 120.0.0)
	/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation (compatibility version 150.0.0, current version 855.14.0)

Please re-check the dependencies and update the port as needed.

[mojca (Mojca Miklavec)]

I have problems finding the following dependencies:

Portfile

@@ -34 +34 @@
 
 depends_lib         port:dbus \
                     port:gettext \
-                    port:gmp \
                     port:gnutls \
-                    port:libgpg-error \
-                    port:libgcrypt \
-                    port:libiconv \
                     port:libidn \
-                    port:nettle \
                     port:sqlite3 \
                     port:xdg-utils
 #                   port:${wxWidgets.port}

Here's an old reference mentioning these dependencies. Maybe FileZilla got rid of them since:

• ​https://forum.filezilla-project.org/viewtopic.php?t=9420

[rudloff@…]

The list of dependencies is available here: ​https://wiki.filezilla-project.org/Compiling_FileZilla_3_under_Mac_OS_X#Building_the_Dependencies

I guess we can try to remove gmp, libiconv and nettle.

[mojca (Mojca Miklavec)]

I don't understand. The site you mentioned lists all thee (gmp, libiconv, nettle), but I'm unable to find any reference to these in the sources, or maybe I don't know how to search.

But it's also true that the site is outdated. wxWidgets 2.8 no longer works for example and the site suggests using version 2.8.

Also, we need to figure out what to do about C++11 ...

[mojca (Mojca Miklavec)]

Version 3.9.0-rc2 is out. What should we do about pre-10.9? Declare it as non-functional and point users to installation of the binary from the official website?

[rudloff@…]

Replying to mojca@…:

I don't understand. The site you mentioned lists all thee (gmp, libiconv, nettle), but I'm unable to find any reference to these in the sources, or maybe I don't know how to search.

Oh, you're right, I read too quickly and didn't see these 3 in it.

Still, I will try tro build without some of these ports to see if they are really necessary.

[rudloff@…]

It seems to build without these dependencies (but gnutls requires gmp and nettle anyway):

Portfile

@@ -34 +34 @@
 
 depends_lib         port:dbus \
                     port:gettext \
-                    port:gmp \
                     port:gnutls \
-                    port:libgpg-error \
-                    port:libgcrypt \
                     port:libiconv \
                     port:libidn \
-                    port:nettle \
                     port:sqlite3 \
                     port:xdg-utils
 #                   port:${wxWidgets.port}

[mojca (Mojca Miklavec)]

I made some changes in r132922 (I had them pending and forgot about this ticket). I didn't check if there is any other dependency that's still there and not used.