Opened 10 years ago

Closed 9 years ago

#45524 closed defect (fixed)

icon @9.5.1_0: requires xorg-libX11

Reported by: dave@… Owned by: michipili (Michael Grünewald)
Priority: Normal Milestone:
Component: ports Version: 2.3.2
Keywords: Cc: kurthindenburg (Kurt Hindenburg)
Port: icon

Description

The icon port should depend on X11, but apparently doesn't. 

--->  Building icon
Error: org.macports.build for port icon returned: command execution failed
Please see the log file for port icon for details:

:info:build make: Entering directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_lang_icon/icon/work/icon-v951src'
:info:build uname -a
:info:build Darwin d.yost.com 14.0.0 Darwin Kernel Version 14.0.0: Tue Sep 23 23:01:41 PDT 2014; root:xnu-2782.1.97~6/RELEASE_X86_64 x86_64
:info:build pwd
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_lang_icon/icon/work/icon-v951src
:info:build cd src/common;		/Applications/Xcode.app/Contents/Developer/usr/bin/make
:info:build make[1]: Entering directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_lang_icon/icon/work/icon-v951src/src/common'
:info:build cc -I /opt/X11/include -o infer infer.c
:info:build ./infer >../h/arch.h
:info:build cc -I /opt/X11/include   -c -o long.o long.c
:info:build In file included from long.c:5:
:info:build In file included from ./../h/gsupport.h:9:
:info:build In file included from ./../h/../h/sys.h:61:
:info:build ./../h/../xpm/xpm.h:20:10: fatal error: 'X11/Xlib.h' file not found
:info:build #include <X11/Xlib.h>
:info:build          ^
:info:build 1 error generated.
:info:build make[1]: *** [long.o] Error 1
:info:build make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_lang_icon/icon/work/icon-v951src/src/common'
:info:build make: *** [Icont] Error 2
:info:build make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_lang_icon/icon/work/icon-v951src'
:info:build Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_lang_icon/icon/work/icon-v951src" && /usr/bin/make -w All 
:info:build Exit code: 2
:error:build org.macports.build for port icon returned: command execution failed

/opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_lang_icon/icon/main.log

After X11 is installed, the icon install works.

Attachments (1)

patch-icon.diff​ (360 bytes) - added by michipili (Michael Grünewald) 9 years ago.
Patch to add missing dependency

Download all attachments as: .zip

Change History (7)

comment:1 Changed 10 years ago by larryv (Lawrence Velázquez)

Keywords: X11 yosemite removed
Milestone: MacPorts 2.3.2
Owner: changed from macports-tickets@… to michael.grunewald@…
Summary: icon port won't build → icon @9.5.1_0: requires xorg-libX11

Changed 9 years ago by michipili (Michael Grünewald)

Attachment: patch-icon.diff​ added

Patch to add missing dependency

comment:2 Changed 9 years ago by michipili (Michael Grünewald)

I attached a patch, I hope it works well for you.

comment:3 Changed 9 years ago by mf2k (Frank Schima)

There is already an x11 variant. So this dependency should only be required when using that variant and X11 should not be required otherwise. Or else the port should remove the x11 variant entirely and depend on xorg-libX11 always.

comment:4 Changed 9 years ago by dave@…

A better solution would be for the non-X11 variant to build correctly without X11.

comment:5 Changed 9 years ago by kurthindenburg (Kurt Hindenburg)

Cc: khindenburg@… added

Cc Me!

comment:6 Changed 9 years ago by kurthindenburg (Kurt Hindenburg)

Resolution: → fixed
Status: new → closed

-x11 works for as-is - r131796 should fix +x11 dependencies

Note: See TracTickets for help on using tickets.