Opened 9 years ago

Closed 9 years ago

#46045 closed enhancement (fixed)

Updated cmus Portfile: enable more features as variants

Reported by: pgf Owned by: g5pw (Aljaž Srebrnič)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: cmus

Description

Attached the updated Portfile for the cmus music player version 2.6.0. I added some variants in order to enable more features:

  • WavPack file support
  • Opus files support
  • ffmpeg support
  • CUE sheets support
  • audio CD playback support (needs libcdio-paranoia proposed port, see ticket:46039)
  • PulseAudio output plugin support
  • JACK output plugin support

I tested the new variants on my platform and everything seems to work fine.

I had to make some change in the PusleAudio configuration file (~/.config/pulse/default.pa) in order to be able to use it:

  • I replaced load-module module-detect with load-module module-coreaudio-detect
  • I commented the line load-module module-console-kit

then I needed to start PulseAudio before launching cmus.

In oder to be able to reproduce audio CDs I had to set device=/dev/rdisk1 where the CD/DVD drive device (disk1 in my case) can be found using mount or diskutil list. Note that mount and diskutil list return /dev/diskN but the cmus device needs to be /dev/rdiskN.

Attachments (1)

Portfile-cmus.diff (2.7 KB) - added by pgf 9 years ago.

Download all attachments as: .zip

Change History (6)

Changed 9 years ago by pgf

Attachment: Portfile-cmus.diff added

comment:1 Changed 9 years ago by mf2k (Frank Schima)

Cc: g5pw@… removed
Keywords: haspatch added
Owner: changed from macports-tickets@… to g5pw@…
Version: 2.3.3

Thanks!

comment:2 Changed 9 years ago by g5pw (Aljaž Srebrnič)

I'm OK with merging the patch, I only have one question: what variants should we enable by default?

comment:3 in reply to:  2 Changed 9 years ago by pgf

Sorry for the late answer.

Replying to g5pw@…:

I'm OK with merging the patch, I only have one question: what variants should we enable by default?

Good point.
Basically, cmus uses a plug and play philosophy, so every variant adds support for one more plugin which is used only when required.
As a comparison, these are the plugins enabled by default under Ubuntu Linux:

  • input: aac cdio ffmpeg flac mad modplug mpc vorbis wav wavpack
  • output: alsa, ao, pulse

My personal opinion is to enable the input plugins for the most common file formats and audio CD playback (aac cdio cue ffmpeg flac mad mikmod mpc vorbis wav wavpack), while leaving the new output plugins disabled by default (pulse, jack).

comment:4 Changed 9 years ago by g5pw (Aljaž Srebrnič)

Done in r132173, thanks.

comment:5 Changed 9 years ago by g5pw (Aljaž Srebrnič)

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.