FileZilla: error: initialization of non-aggregate type (on 10.8 only)

[mojca (Mojca Miklavec)]

The ​Mountain Lion buildbot fails with:

/usr/bin/clang++ -DHAVE_CONFIG_H -I. -I../../src/include  -I./../include -I/opt/local/include -I/opt/local/include/p11-kit-1 -I/opt/local/include  -I/opt/local/Library/Frameworks/wxWidgets.framework/Versions/wxWidgets/3.0-libcxx/lib/wx/include/osx_cocoa-unicode-3.0 -I/opt/local/Library/Frameworks/wxWidgets.framework/Versions/wxWidgets/3.0-libcxx/include/wx-3.0 -D_FILE_OFFSET_BITS=64 -DWXUSINGDLL -D__WXMAC__ -D__WXOSX__ -D__WXOSX_COCOA__ -I/opt/local/include -fpch-preprocess -I/opt/local/Library/Frameworks/wxWidgets.framework/Versions/wxWidgets/3.0-libcxx/lib/wx/include/osx_cocoa-unicode-3.0 -I/opt/local/Library/Frameworks/wxWidgets.framework/Versions/wxWidgets/3.0-libcxx/include/wx-3.0 -D_FILE_OFFSET_BITS=64 -DWXUSINGDLL -D__WXMAC__ -D__WXOSX__ -D__WXOSX_COCOA__ -pipe -Os -arch x86_64 -stdlib=libc++ -Wall -g -std=gnu++11 -MT libengine_a-event_handler.o -MD -MP -MF .deps/libengine_a-event_handler.Tpo -c -o libengine_a-event_handler.o `test -f 'event_handler.cpp' || echo './'`event_handler.cpp
engineprivate.cpp:15:63: error: initialization of non-aggregate type 'std::atomic_int' (aka 'atomic<int>') with an initializer list
std::atomic_int CFileZillaEnginePrivate::m_activeStatus[2] = {{0}, {0}};
                                                              ^~~
engineprivate.cpp:15:68: error: initialization of non-aggregate type 'std::atomic_int' (aka 'atomic<int>') with an initializer list
std::atomic_int CFileZillaEnginePrivate::m_activeStatus[2] = {{0}, {0}};
                                                                   ^~~

While ​Lion works OK.

[mojca (Mojca Miklavec)]

Potentially relevant commit:

• ​http://svn.filezilla-project.org/filezilla?view=revision&revision=6445

[asedeno@…]

Cc Me!

[mojca (Mojca Miklavec)]

• ​https://llvm.org/bugs/show_bug.cgi?id=12670
• ​http://llvm.org/viewvc/llvm-project?view=revision&revision=159896

[mojca (Mojca Miklavec)]

Apparently we need to blacklist some old compilers. Weird enough it seems as if the buildbots contain:

• 10.7: Apple LLVM version 4.2 (clang-425.0.28) (based on LLVM 3.2svn); Xcode 4.6.2 or 4.6.3
• 10.8: Apple clang version 4.1 (tags/Apple/clang-421.11.66) (based on LLVM 3.1svn); Xcode 4.5.1 or 4.5.2

The bug has been fixed in July 2012. Version 3.2 came out in December 2012. I would assume that any version prior to 3.2 should be blacklisted (and that version 3.2 already contains that patch). And probably anything below clang 425. But I would need additional testers on 10.8.

[mojca (Mojca Miklavec)]

Commits r134481 & r134482 fixed the problem by blacklisting an old compiler. It's weird enough that the compiler on the buildbot is so old though.

[ryandesign (Ryan Carsten Schmidt)]

Replying to mojca@…:

It's weird enough that the compiler on the buildbot is so old though.

Filed #47299 for this.

[mojca (Mojca Miklavec)]

I blacklisted some more compilers (anything older than clang 3.4) in r141832 because FileZilla now wants C++1y. I made my decision based on XcodeVersionInfo, so maybe I missed some compilers. If so, let me know.