Opened 9 years ago

Closed 8 years ago

#47572 closed defect (fixed)

xfce4-settings @4.6.5 fails to build due to a change in libnotify

Reported by: wyatt8750@… Owned by: afb@…
Priority: Normal Milestone:
Component: ports Version: 2.3.3
Keywords: haspatch Cc: cooljeanius (Eric Gallager)
Port: xfce4-settings

Description

LibNotify's notify_notification_new() now takes fewer arguments than it used to, and the version of xfce4-settings in macports is still using the old argument count. Line 420 in accessibility is to blame, and it can be made to compile by doing something like this:

--- old/xfce4-settings-4.6.5/xfce4-settings-helper/accessibility.c	2015-04-25 19:55:26.000000000 -0400
+++ xfce4-settings-4.6.5/xfce4-settings-helper/accessibility.c	2015-04-25 19:55:36.000000000 -0400
@@ -417,7 +417,7 @@
     if (helper->notification == NULL)
     {
         /* create a new notification */
-        helper->notification = notify_notification_new (summary, body, "keyboard", NULL);
+        helper->notification = notify_notification_new (summary, body, "keyboard");
 
         /* close signal */
         g_signal_connect (G_OBJECT (helper->notification), "closed", G_CALLBACK (xfce_accessibility_helper_notification_closed), helper);

I don't know if my paths in that patch are correct, but this did seem to fix my issue. If it matters, I am running OS X 10.6.8 (snow leopard) with xcode 4.2's SDK. The patch is also attached, as is the original build log.

Attachments (2)

main.log.bz2 (16.0 KB) - added by wyatt8750@… 9 years ago.
Original main.log containing the build error
xfce4-settings.patch (654 bytes) - added by wyatt8750@… 9 years ago.
a patch that should allow xfce4-settings to build with the change in libnotify. I have not tested to make sure that this does not break anything, I just know that it builds with this.

Download all attachments as: .zip

Change History (6)

Changed 9 years ago by wyatt8750@…

Attachment: main.log.bz2 added

Original main.log containing the build error

Changed 9 years ago by wyatt8750@…

Attachment: xfce4-settings.patch added

a patch that should allow xfce4-settings to build with the change in libnotify. I have not tested to make sure that this does not break anything, I just know that it builds with this.

comment:1 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: afb@… removed
Owner: changed from macports-tickets@… to afb@…
Summary: xfce4-settings @@ 4.6.5 fails to build due to a change in libnotifyxfce4-settings @4.6.5 fails to build due to a change in libnotify

Perhaps we should try updating the port to the current version (4.12) first.

comment:2 Changed 9 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

comment:3 Changed 9 years ago by wyatt8750@…

Maybe updating would be a good move.

comment:4 Changed 8 years ago by afb@…

Resolution: fixed
Status: newclosed

Fixed, r144133.

Note: See TracTickets for help on using tickets.