Opened 9 years ago

Closed 6 years ago

#47837 closed update (fixed)

port:exiv2 upgrade (also addresses a current crash)

Reported by: RJVB (René Bertin) Owned by: \
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: dbevans (David B. Evans), mkae (Marko Käning)
Port: exiv2

Description

exiv2 can crash attempting to extract the metadata from certain QuickTime movies. This bug is still present in the current svn/head, but at least that version provides an option to disable support for video (which doesn't have EXIF data anyway, AFAIK).

I reported the bug: http://dev.exiv2.org/issues/1088 .

Attached is a patch to upgrade port:exiv2 to the latest version, introducing a +video variant to enable support for video metadata for those who can live with the risk of crashing.

This update also adds the cmake.out_of_source yes command that was still missing.

Attachments (2)

patch-deactivate-QT-userdata.diff (621 bytes) - added by RJVB (René Bertin) 9 years ago.
exiv2.diff (2.0 KB) - added by RJVB (René Bertin) 9 years ago.

Download all attachments as: .zip

Change History (11)

Changed 9 years ago by RJVB (René Bertin)

Changed 9 years ago by RJVB (René Bertin)

Attachment: exiv2.diff added

comment:1 Changed 9 years ago by RJVB (René Bertin)

I've "stubbified" the function containing the higher-level operation during which the crash occurs, so +video can be made a default variant in order to avoid feature loss w.r.t. the current port:exiv2 .

comment:2 Changed 9 years ago by dbevans (David B. Evans)

Cc: tcurdt@… removed
Owner: changed from macports-tickets@… to tcurdt@…

comment:3 Changed 9 years ago by dbevans (David B. Evans)

Cc: devans@… added

I'm not sure what the good of upgrading to SVN head is (other than for testing) if the problem persists there as well. Normally one would stick to stable upstream releases with patches to fix the issue if possible. If it is desireable to provide the upstream development version, a *-devel version of the port is typically provided.

comment:4 Changed 9 years ago by mkae (Marko Käning)

Cc: mk@… added

Cc Me!

comment:5 Changed 9 years ago by larryv (Lawrence Velázquez)

Why is the subversion port necessary? What’s wrong with Xcode’s Subversion?

And please remove the if {[file exists ${filespath}/${name}-svn/.svn]} testing detritus.

comment:6 Changed 9 years ago by RJVB (René Bertin)

How does one unCC from a ticket?

comment:7 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)

You can Cc and un-Cc yourself by clicking the "CcMe!" button.

On this ticket, you are not Cc'd, you are the reporter, so if you are wanting to stop receiving mail about this ticket, we would have to change the ticket's reporter address to something other than your address.

comment:8 Changed 7 years ago by kurthindenburg (Kurt Hindenburg)

Owner: changed from tcurdt@… to \
Status: newassigned

comment:9 Changed 6 years ago by mf2k (Frank Schima)

Resolution: fixed
Status: assignedclosed

This port has been updated to 0.26 sometime in the past.

Note: See TracTickets for help on using tickets.