Opened 8 years ago
Last modified 9 months ago
#49924 assigned enhancement
attica : move Qt4/KDE4 headers and add Qt5 subport
| Reported by: | RJVB (René Bertin) | Owned by: | RJVB (René Bertin) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch | Cc: | mkae (Marko Käning) |
| Port: | attica |
Description (last modified by mf2k (Frank Schima))
This supersedes and replaces ticket #49109 , and depends on ticket #49595
- attica (for Qt4/KDE4) installs its headers into ${prefix}/include/attica, where they can be picked up instead of those from the KF5 version (port submission pending). Rather than fixing the the build system in an unknown number of dependent ports, it is more convenient to move the headers of the KDE4 version into the KDE4-specific headerfile prefix which is required anyway (see ticket #49595).
(Note that revbumps shouldn't be required for this kind of change.)
- adds a Qt5 subport. I'm not convinced this one is very useful once kf5-attica is available; it should probably be marked as replaced_by that one, in due time. See #49109 for the Qt5-specific patchfiles.
Attachments (2)
Change History (10)
Changed 8 years ago by RJVB (René Bertin)
| Attachment: | patch-includedir.diff added |
|---|
Changed 8 years ago by RJVB (René Bertin)
| Attachment: | patch-attica.diff added |
|---|
comment:1 Changed 8 years ago by mf2k (Frank Schima)
| Cc: | nicos@… removed |
|---|---|
| Description: | modified (diff) |
| Owner: | changed from macports-tickets@… to nicos@… |
comment:2 Changed 8 years ago by mkae (Marko Käning)
| Cc: | mk@… added |
|---|
comment:3 Changed 8 years ago by mkae (Marko Käning)
Is this ticket related to #52689?
I don't think this should be committed as is, as there are no kf5 ports yet.
comment:4 Changed 8 years ago by RJVB (René Bertin)
Yes, it is.
The qt5 subport is now redundant (or at least will be when kf5-attica is released) but I would argue that the other changes (to the header files) can be applied without danger as long as the KDE4 portgroup gets the necessary changes too.
In my opinion it would really be a good idea to test and push my proposed changes for KF5 compatibility first so they see real testing "in the wild" before we start publishing KF5 ports.
comment:6 follow-up: 7 Changed 9 months ago by barracuda156
What happened to this? (I use Qt4 myself, but having an option to use Qt5 makes perfect sense.)
comment:7 Changed 9 months ago by RJVB (René Bertin)
Replying to barracuda156:
What happened to this?
In one word: abandoned.
The proposed change was provisional. I do have a kf5-attica port in my own tree, part of my KF5 project which turned out unfeasible to get added to MacPorts, and which is on life-support even in my own tree.
Attica is a so-called Tier1 framework, which means the only other KDE software it depends on are the extra-cmake-modules.
The current version probably requires Qt6, though.
comment:8 Changed 9 months ago by RJVB (René Bertin)
| Owner: | changed from NicosPavlov to RJVB |
|---|---|
| Status: | new → assigned |
Cc Me!