Changes between Initial Version and Version 1 of Ticket #50782, comment 15
- Timestamp:
- Apr 25, 2016, 2:45:22 AM (8 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #50782, comment 15
initial v1 1 I suggested to treat {{{default_variants}}} as same as manually set variants and we had a lengthy discussion, but I don't think we agree to fix the behaviour. So I decoupled ncarg from hdf5(-18) and removed mpi.enforce_variant in r148018 in r148018. ncarg does not contain any MPI source and does not depend on hdf5(-18). I use h5cc and h5pcc for convenience; this is what this port used to be. OpenMP code is not used when the default C compiler system clang is used but I believe it is less important than the build error and a lack of a binary package; it seems that OpenMP was not effective according to [https://www2.cisl.ucar.edu/siparcs/calendar/2013-08-01/ping-guo/evaluating-interaction-between-network-routing-and-applica this abstract]. In addition I replaced {{{reinplace}}} with patches where possible.1 I suggested to treat {{{default_variants}}} as same as manually set variants and we had a lengthy discussion, but I don't think we agree to fix the behaviour. So I decoupled ncarg from hdf5(-18) and removed mpi.enforce_variant in r148018. ncarg does not contain any MPI source and does not depend on hdf5(-18). I use h5cc and h5pcc for convenience; this is what this port used to be. OpenMP code is not used when the default C compiler system clang is used but I believe it is less important than the build error and a lack of a binary package; it seems that OpenMP was not effective according to [https://www2.cisl.ucar.edu/siparcs/calendar/2013-08-01/ping-guo/evaluating-interaction-between-network-routing-and-applica this abstract]. In addition I replaced {{{reinplace}}} with patches where possible.