Changes between Initial Version and Version 1 of Ticket #52224, comment 3
- Timestamp:
- Sep 15, 2016, 5:08:36 PM (8 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #52224, comment 3
initial v1 1 The reason I originally suggested incorporating this patch was because it's a regression introduced in 2.2 (neither older nor newer versions of tmux have the bug), the fix is trivial, and if applied it removed a warning message when tmux is run in macOS 10.12. The warning was really from libevent, and that port has been fixed after I opened this ticket, so at least one of the justifications for integrating this patch has disappeared.1 The reason why I originally suggested incorporating this patch was because it's a regression introduced in 2.2 (neither older nor newer versions of tmux have the bug), the fix is trivial, and if applied it removed a warning message when tmux is run in macOS 10.12. The warning was really from libevent, and that port has been fixed after I opened this ticket, so at least one of the justifications for integrating this patch has disappeared. 2 2 3 3 Honestly if I were the maintainer I would still integrate this specific patch just to avoid the hard-to-diagnose glitches that you may encounter when events happen to be missed, but I have to concede that this just due to my own preference — I happen to prefer to run stable versions with a few backported patches here and there than running pre-release versions — and the bug was not considered important enough by upstream to justify a new patch release. I understand that you as the maintainer may be afraid of setting a precedent and wants to avoid having to make a value judgment for every future patch that is not yet incorporated into an official release. If you prefer not to add the patch, I certainly get your point and I won't object.