Projects
New Ticket     Wiki     Browse Source     Timeline     Roadmap     Bug Reports     Search

Ticket #7361 (closed defect: fixed)

Opened 3 years ago

Last modified 6 weeks ago

BUG: activation status of dependencies is not checked before installation

Reported by: opendarwin.nospam@… Owned by: macports-tickets@…
Priority: High Milestone: MacPorts 1.7.0
Component: base Version:
Keywords: haspatch Cc: vinc17@…, rhwood@…, jmr@…
Port:

Description (last modified by jmpp@…) (diff)

assuming i want to install port A that depends on port B. in case that port B is already installed but currently not activated for some reason, "port install portA" does not complain and begins to install port A nonetheless. the installation will most likely fail in the configure, or build phase because it cannot locate port B that it depends on.

this has bitten me several times by now and can be quite confusing, especially when a port is unintentionally inactive due to a prior installation/activation error.

i really would expect that darwinports moans when i try to install a port that has inactive dependencies. imho it should spit out a warning at least.

Attachments

_mportispresent.diff (2.1 KB) - added by jmr@… 7 months ago.
proposed fix

Change History

  Changed 3 years ago by opendarwin.nospam@…

  • summary changed from activation status of dependencies is not checked before installation to BUG: activation status of dependencies is not checked before installation

  Changed 21 months ago by pipping@…

  • milestone set to Port Bugs

  Changed 21 months ago by pipping@…

  • milestone changed from Port Bugs to MacPorts 1.4

  Changed 21 months ago by jmpp@…

  • owner changed from macports-tickets@… to macports-dev@…
  • priority changed from Expected to Important
  • description modified (diff)
  • severity changed from normal to Normal
  • milestone changed from MacPorts 1.4 to Needs developer review

  Changed 16 months ago by jmpp@…

  • milestone changed from Needs developer review to MacPorts base bugs

Milestone Needs developer review deleted

  Changed 16 months ago by nox@…

  • priority changed from Important to High
  • version 1.2 deleted

  Changed 14 months ago by vinc17@…

  • cc vinc17@… added

Any news?

  Changed 8 months ago by rhwood@…

  • cc rhwood@… added

This bug has bitten us badly with the replacement of scrollkeeper with rarian. The problem was that for the most part, rarian was automatically installed as a dependency of other ports before scrollkeeper could be removed, so rarian is sitting around inactive on systems where it should be active.

See also #14971

  Changed 7 months ago by jmr@…

  • keywords haspatch added
  • milestone changed from MacPorts base bugs to MacPorts 1.6.1

Nominating for the upcoming release.

  Changed 7 months ago by jmr@…

  • cc jmr@… added

follow-up: ↓ 12   Changed 7 months ago by raimue@…

Image mode is still optional and users can still choose not to use it in macports.conf. Therefore there should be a distinction whether we are in image mode or not.

in reply to: ↑ 11   Changed 7 months ago by jmr@…

Replying to raimue@macports.org:

Image mode is still optional and users can still choose not to use it in macports.conf. Therefore there should be a distinction whether we are in image mode or not.

Attaching a new patch that checks that, and also checks for activation in another place I missed before.

Changed 7 months ago by jmr@…

proposed fix

  Changed 7 months ago by jmr@…

Committed the patch to trunk in r36735. There is a corner case where if you've selected different variants when installing the dependent than the inactive dependency was built with, a new version of the dependency will be built with the new variants (instead of the existing version being activated). I'm not sure if this should be considered a bug or a feature.

  Changed 6 weeks ago by jmr@…

  • status changed from new to closed
  • resolution set to fixed

Closing since 1.6.1 has turned into 1.7.

Note: See TracTickets for help on using tickets.