Opened 18 years ago

Closed 18 years ago

#8669 closed defect (fixed)

BUG: caches are bypassed when fetching distfiles

Reported by: josh_root@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: base Version: 1.2
Keywords: Cc:
Port:

Description

A "Pragma: no-cache" header is always sent when DP fetches distfiles via HTTP. There doesn't seem to be any good reason for this to be the default behaviour, it's just wasting bandwidth.

Attachments (1)

curl.c.diff (1.2 KB) - added by blb@… 18 years ago.
Patch to base

Download all attachments as: .zip

Change History (5)

Changed 18 years ago by blb@…

Attachment: curl.c.diff added

Patch to base

comment:1 Changed 18 years ago by jberry@…

I know I'm dense, but, a couple of questions...

So we use curl as a client. Whether or not we send a no-cache header, it shouldn't mean much of anything (unless there's a proxy involved?) since the server presumably doesn't respond to it. So this bug reports that we should change the default's used by curl because we use a few extra bytes in request headers over the wire?

Just making sure I'm clear..

comment:2 Changed 18 years ago by josh_root@…

No, I'm not worried about the header being sent per se. It's the result it causes with caching proxies, as you guessed. There's people (like me) who run Squid on their LAN, and lots of ISPs use a transparent proxy to cache HTTP traffic.

comment:3 Changed 18 years ago by josh_root@…

I tested the patch and it appears to have the desired effect.

comment:4 Changed 18 years ago by pguyot (Paul Guyot)

Resolution: fixed
Status: newclosed

Thanks. Committed.

Note: See TracTickets for help on using tickets.