Ticket #45309: glib2-45309.patch

Portfile

@@ -11 +11 @@
 conflicts                   glib2-devel
 set my_name                 glib
 version                     2.42.0
+revision                    1
 set branch                  [join [lrange [split ${version} .] 0 1] .]
 categories                  devel
 maintainers                 ryandesign openmaintainer
@@ -43 +44 @@
                             patch-gio_xdgmime_xdgmime.c.diff \
                             patch-gio_gdbusprivate.c.diff \
                             patch-get-launchd-dbus-session-address.diff \
+                            patch-gmodule-gmodule-dl.c.diff \
                             yosemite-symbol-lookup.patch
 
 depends_build               bin:xmllint:libxml2

files/patch-gmodule-gmodule-dl.c.diff

@@ +1 @@
+--- gmodule/gmodule-dl.c.orig   2014-07-04 16:59:10.000000000 -0700
++++ gmodule/gmodule-dl.c        2014-11-03 10:53:31.000000000 -0800
+@@ -126,16 +126,18 @@ static void
+ _g_module_close (gpointer handle,
+                 gboolean is_unref)
+ {
+-  /* are there any systems out there that have dlopen()/dlclose()
+-   * without a reference count implementation?
++  /* Intentionally not dlclose()ing because it is safer to leave the library
++   * loaded in memory than to close it and possibly leave dangling pointers
++   * to things like atexit handlers, atfork handlers, blocks, etc.
++   *
++   * See https://trac.macports.org/ticket/45309 for an example from when
++   * a library used by a module added a new dependency which had an
++   * initializer which added a child atfork handler.  The result is that
++   * after closing the module, the system had a dangling pointer for the
++   * atfork handler which would at best crash on the child side of fork()
++   * and at worst lead to arbitray code execution of whatever happened to be
++   * at that location in memory at a later time in the process.
+    */
+-  is_unref |= 1;
+-  
+-  if (is_unref)
+-    {
+-      if (dlclose (handle) != 0)
+-       g_module_set_error (fetch_dlerror (TRUE));
+-    }
+ }
+ 
+ static gpointer