Changeset 141404 for trunk/base


Ignore:
Timestamp:
Oct 17, 2015, 4:18:03 PM (4 years ago)
Author:
cal@…
Message:

base: darwintrace: Make notes where I sometimes see crashes

I did migration to El Capitan with trace mode enabled and used the crash
generated crash reports to track down where darwintrace breaks stuff in
practice. This document these locations with a FIXME so they can be fixed some
time.

Location:
trunk/base/src/darwintracelib1.0
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/base/src/darwintracelib1.0/darwintrace.c

    r138935 r141404  
    776776                /*           attrlength         attrref_t for the name     UTF-8 name up to PATH_MAX chars */
    777777
     778                // FIXME This sometimes violates the stack canary
    778779                if (-1 == (getattrlist(".", &attrlist, attrbuf, sizeof(attrbuf), FSOPT_NOFOLLOW))) {
    779780                        perror("darwintrace: getattrlist");
  • trunk/base/src/darwintracelib1.0/readdir.c

    r117962 r141404  
    7272
    7373        size_t sz = __getdirentries64(fd, buf, bufsize, basep);
     74        // FIXME Support longer paths
    7475        char dirname[MAXPATHLEN];
    7576        size_t dnamelen;
     
    9293                struct dirent64 *dent = (struct dirent64 *)(((char *) buf) + offset);
    9394                dirname[dnamelen] = '\0';
     95                // FIXME This crashes sometimes
    9496                strcat(dirname, dent->d_name);
    9597                if (!__darwintrace_is_in_sandbox(dirname, DT_ALLOWDIR)) {
Note: See TracChangeset for help on using the changeset viewer.