Changeset 18822 for trunk/base


Ignore:
Timestamp:
Jul 30, 2006, 6:48:50 PM (14 years ago)
Author:
jmpp
Message:

Submitted by: jmpp@

Per Paul's advice, downgraded a possible chmod failure to a warning,
rather than erroring out on it.

On the other hand, overlooking jberry's recent advice to pass -f to chmod(1),
as I believe we should catch and warn the user if parts of his/her dports tree
are not world readable.

All and all, this is still just a hack, if anyone has a better fix (the issue
being that in some situations the dports tree might not be readable to the user,
like after sync'ing for the first time with a quite restrictive umask) please
do feel free to step in and contribute. Keeping in only in HEAD for the moment,
maybe up for a future 1.3.2.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/base/src/darwinports1.0/darwinports.tcl

    r18817 r18822  
    11# darwinports.tcl
    2 # $Id: darwinports.tcl,v 1.216 2006/07/30 18:04:46 jmpp Exp $
     2# $Id: darwinports.tcl,v 1.217 2006/07/30 18:48:50 jmpp Exp $
    33#
    44# Copyright (c) 2002 Apple Computer, Inc.
     
    10981098                                }
    10991099                                if {[catch {system "chmod -R a+r \"$destdir\""}]} {
    1100                                     return -code error "Setting world read permissions on \"$destdir\" failed, need root?"
     1100                                    ui_warn "Setting world read permissions on parts of the ports tree failed, need root?"
    11011101                                }
    11021102                        }
Note: See TracChangeset for help on using the changeset viewer.