Opened 14 years ago

Closed 12 years ago

Last modified 12 years ago

#10642 closed defect (fixed)

BUG: py-game-1.7.1 won't build on 10.3

Reported by: darren.bane@… Owned by: ben@…
Priority: High Milestone:
Component: ports Version:
Keywords: Cc: markd@…, simon@…, felix.engel@…
Port:

Description

py-game-1.7.1

the error log can be found here: INLINE

Description: Broken build on 10.3

==========INLINE CONTENT========== !snip!

building 'pygame.display' extension gcc -fno-strict-aliasing -Wno-long-double -no-cpp-precomp -mno-fused-madd -fno-common -fno-common -dynamic -DNDEBUG -g -O3 -Wall -Wstrict-prototypes -Ddarwin -I/opt/local/include/SDL -I/opt/local/Library/Frameworks/Python.framework/Versions/2.4/include/python2.4 -I/opt/local/include/python2.4 -c src/display.c -o build/temp.darwin-7.9.0-Power_Macintosh-2.4/src/display.o src/display.c: In function `get_wm_info': src/display.c:432: error: structure has no member named `data' error: command 'gcc' failed with exit status 1

Error: Status 1 encountered during processing.

Change History (14)

comment:1 Changed 14 years ago by darren.bane@…

Attaching files doesn't seem to work yet (permissions error), so here are my patches:

--begin patch-Portfile----------

--- Portfile.orig	Sun Sep  3 02:00:17 2006
+++ Portfile	Sun Sep  3 02:00:31 2006
@@ -28,7 +28,8 @@
 
 depends_run		port:py-pyobjc
 
-patchfiles		patch-config_darwin.py
+patchfiles		patch-config_darwin.py \
+			patch-display.c
 
 use_configure	yes
 

--end patch-Portfile----------

--begin patch-display.c----------

--- display.c.orig	Sun Sep  3 01:50:07 2006
+++ display.c	Sun Sep  3 01:58:30 2006
@@ -428,7 +428,7 @@
 		PyDict_SetItemString(dict, "window", PyInt_FromLong(info.window));
 		PyDict_SetItemString(dict, "wimpVersion", PyInt_FromLong(info.wimpVersion));
 		PyDict_SetItemString(dict, "taskHandle", PyInt_FromLong(info.taskHandle));
-#else
+#elif !(defined(__APPLE__) && defined(__MACH__))
 		PyDict_SetItemString(dict, "data", PyInt_FromLong(info.data));
 #endif
 		

--end patch-display.c----------

comment:2 Changed 14 years ago by markd@…

Cc: ben@… markd@… added

I've heard that it is necessary to cc as well as asign to someone. Not sure if true, but just in case I'm ccing maintainer.

comment:3 Changed 14 years ago by rnichol_rrc@…

I can verify this problem on OS 10.4.8 with a Macport install of just a few hours old.

The one issue that there exists with the above patch is that this:

--- display.c.orig Sun Sep 3 01:50:07 2006 +++ display.c Sun Sep 3 01:58:30 2006

Should actually be:

--- src/display.c.orig Sun Sep 3 01:50:07 2006 +++ src/display.c Sun Sep 3 01:58:30 2006

I tested the above patch with:

http://pygame.org/projects/20/262/

And it worked fine.

Would someone finally commit this, please?

comment:4 Changed 14 years ago by Martin.Buchmann@…

Could please someone explain me how to apply the this patch manually? I tried to find the files in the /opt/local tree bit got terribly lost :-( Or even better why is the patch not yet commited?

comment:5 Changed 14 years ago by Martin.Buchmann@…

Okay, got I :-) I just the -dv options during installation and so got the path to look in. Now I could apply the patches and it works like a charm :-)

comment:6 Changed 14 years ago by markd@…

Resolution: fixed
Status: newclosed

Patch committed. Thanks!

comment:7 Changed 13 years ago by MartinBuchmann (Martin Buchmann)

Resolution: fixed
Status: closedreopened

Hi,

I am facing this bug again on a vanilla MacBook running 10.4.10, MacPorts 1.50 and Xcode 2.41. I tried to install py-game and ended up with this:

building 'pygame.display' extension /usr/bin/gcc-4.0 -fno-strict-aliasing -Wno-long-double -no-cpp-precomp -fno-common -fno-common -dynamic -DNDEBUG -g -O3 -Wall -Wstrict-prototypes -Ddarwin -I/opt/local/include/SDL -I/opt/local/Library/Frameworks/Python.framework/Versions/2.4/include/python2.4 -c src/display.c -o build/temp.macosx-10.3-i386-2.4/src/display.o In file included from src/display.c:28: /opt/local/include/SDL/SDL_syswm.h:55:22: error: X11/Xlib.h: No such file or directory /opt/local/include/SDL/SDL_syswm.h:56:23: error: X11/Xatom.h: No such file or directory In file included from src/display.c:28: /opt/local/include/SDL/SDL_syswm.h:73: error: parse error before 'XEvent' /opt/local/include/SDL/SDL_syswm.h:73: warning: no semicolon at end of struct or union /opt/local/include/SDL/SDL_syswm.h:73: warning: no semicolon at end of struct or union /opt/local/include/SDL/SDL_syswm.h:74: warning: type defaults to 'int' in declaration of 'event' /opt/local/include/SDL/SDL_syswm.h:74: warning: data definition has no type or storage class /opt/local/include/SDL/SDL_syswm.h:75: error: parse error before '}' token /opt/local/include/SDL/SDL_syswm.h:86: error: parse error before 'Display' /opt/local/include/SDL/SDL_syswm.h:86: warning: no semicolon at end of struct or union /opt/local/include/SDL/SDL_syswm.h:86: warning: no semicolon at end of struct or union /opt/local/include/SDL/SDL_syswm.h:86: warning: no semicolon at end of struct or union /opt/local/include/SDL/SDL_syswm.h:87: warning: type defaults to 'int' in declaration of 'window' /opt/local/include/SDL/SDL_syswm.h:87: warning: data definition has no type or storage class /opt/local/include/SDL/SDL_syswm.h:97: error: parse error before 'fswindow' /opt/local/include/SDL/SDL_syswm.h:97: warning: type defaults to 'int' in declaration of 'fswindow' /opt/local/include/SDL/SDL_syswm.h:97: warning: data definition has no type or storage class /opt/local/include/SDL/SDL_syswm.h:98: error: parse error before 'wmwindow' /opt/local/include/SDL/SDL_syswm.h:98: warning: type defaults to 'int' in declaration of 'wmwindow' /opt/local/include/SDL/SDL_syswm.h:98: warning: data definition has no type or storage class /opt/local/include/SDL/SDL_syswm.h:99: warning: type defaults to 'int' in declaration of 'x11' /opt/local/include/SDL/SDL_syswm.h:99: warning: data definition has no type or storage class /opt/local/include/SDL/SDL_syswm.h:100: error: parse error before '}' token /opt/local/include/SDL/SDL_syswm.h:100: warning: type defaults to 'int' in declaration of 'info' /opt/local/include/SDL/SDL_syswm.h:100: warning: data definition has no type or storage class /opt/local/include/SDL/SDL_syswm.h:101: error: parse error before '}' token /opt/local/include/SDL/SDL_syswm.h:101: warning: type defaults to 'int' in declaration of 'SDL_SysWMinfo' /opt/local/include/SDL/SDL_syswm.h:101: warning: data definition has no type or storage class /opt/local/include/SDL/SDL_syswm.h:201: error: parse error before '*' token /opt/local/include/SDL/SDL_syswm.h:201: warning: function declaration isn't a prototype src/display.c: In function 'get_wm_info': src/display.c:400: error: parse error before 'info' src/display.c:407: error: request for member 'version' in something not a structure or union src/display.c:407: error: request for member 'version' in something not a structure or union src/display.c:407: error: request for member 'version' in something not a structure or union error: command '/usr/bin/gcc-4.0' failed with exit status 1 Error: Target org.macports.build returned: shell command " cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_python_py-game/work/pygame-1.7.1release" && /opt/local/bin/python2.4 setup.py build " returned error 1 Command output: /opt/local/include/SDL/SDL_syswm.h:74: warning: data definition has no type or storage class /opt/local/include/SDL/SDL_syswm.h:75: error: parse error before '}' token /opt/local/include/SDL/SDL_syswm.h:86: error: parse error before 'Display' /opt/local/include/SDL/SDL_syswm.h:86: warning: no semicolon at end of struct or union /opt/local/include/SDL/SDL_syswm.h:86: warning: no semicolon at end of struct or union /opt/local/include/SDL/SDL_syswm.h:86: warning: no semicolon at end of struct or union /opt/local/include/SDL/SDL_syswm.h:87: warning: type defaults to 'int' in declaration of 'window' /opt/local/include/SDL/SDL_syswm.h:87: warning: data definition has no type or storage class /opt/local/include/SDL/SDL_syswm.h:97: error: parse error before 'fswindow' /opt/local/include/SDL/SDL_syswm.h:97: warning: type defaults to 'int' in declaration of 'fswindow' /opt/local/include/SDL/SDL_syswm.h:97: warning: data definition has no type or storage class /opt/local/include/SDL/SDL_syswm.h:98: error: parse error before 'wmwindow' /opt/local/include/SDL/SDL_syswm.h:98: warning: type defaults to 'int' in declaration of 'wmwindow' /opt/local/include/SDL/SDL_syswm.h:98: warning: data definition has no type or storage class /opt/local/include/SDL/SDL_syswm.h:99: warning: type defaults to 'int' in declaration of 'x11' /opt/local/include/SDL/SDL_syswm.h:99: warning: data definition has no type or storage class /opt/local/include/SDL/SDL_syswm.h:100: error: parse error before '}' token /opt/local/include/SDL/SDL_syswm.h:100: warning: type defaults to 'int' in declaration of 'info' /opt/local/include/SDL/SDL_syswm.h:100: warning: data definition has no type or storage class /opt/local/include/SDL/SDL_syswm.h:101: error: parse error before '}' token /opt/local/include/SDL/SDL_syswm.h:101: warning: type defaults to 'int' in declaration of 'SDL_SysWMinfo' /opt/local/include/SDL/SDL_syswm.h:101: warning: data definition has no type or storage class /opt/local/include/SDL/SDL_syswm.h:201: error: parse error before '*' token /opt/local/include/SDL/SDL_syswm.h:201: warning: function declaration isn't a prototype src/display.c: In function 'get_wm_info': src/display.c:400: error: parse error before 'info' src/display.c:407: error: request for member 'version' in something not a structure or union src/display.c:407: error: request for member 'version' in something not a structure or union src/display.c:407: error: request for member 'version' in something not a structure or union error: command '/usr/bin/gcc-4.0' failed with exit status 1

Warning: the following items did not execute (for py-game): org.macports.activate org.macports.build org.macports.destroot org.macports.install Error: Status 1 encountered during processing. metallw06:~ Martin$

I've checked the patch file, it is there and the port file is modified but it seems that something else is wrong here.

Does anyone know what's going on?

Any help is appreciated

Martin

comment:8 Changed 13 years ago by markd@…

I just installed it on 10.4.10 MacBook with no problems. I think there were some recent updates to libsdl, Does "port outdated" list any newer versions of py-games dependencies?

comment:9 Changed 13 years ago by ben@…

Cc: ben@… removed

comment:10 Changed 13 years ago by MartinBuchmann (Martin Buchmann)

Hmm, I just did a selfupdate and resync and it seems that nothing is outdated here. I have the following libs installed:

libsdl @1.2.11_0+darwin_8 (active) libsdl_image @1.2.5_1+darwin_8 (active) libsdl_mixer @1.2.7_0+darwin_8 (active) libsdl_ttf @2.0.8_1+darwin_8 (active)

I did a clean --all on py-game but it still fails as stated above.

Puzzled

Martin

comment:11 Changed 13 years ago by nox@…

Milestone: Port Bugs
Priority: BlockerHigh
Version: 1.3.1

comment:12 Changed 13 years ago by felix.engel@…

I see the same error on OSX 10.4.11, macports 1.6.0, py-game 1.7.1. The include path for X11 is not set:

/opt/local/include/SDL/SDL_syswm.h:55:22: error: X11/Xlib.h: No such file or directory /opt/local/include/SDL/SDL_syswm.h:56:23: error: X11/Xatom.h: No such file or directory In file included 

I could override it in Setup and then build and install py-game. (I have not been able to use the software I actually wanted to use, but that is probably a different problem)

comment:13 Changed 12 years ago by simon@…

Cc: simon@… felix.engel@… added
Resolution: fixed
Status: reopenedclosed

This should be fixed in r36726. Thanks for your reports.

Simon

comment:14 Changed 12 years ago by (none)

Milestone: Port Bugs

Milestone Port Bugs deleted

Note: See TracTickets for help on using tickets.