Opened 14 years ago

Closed 14 years ago

#10852 closed defect (fixed)

[PATCH] Add no_program_prefix variant and depend upon gettext

Reported by: blair (Blair Zajac) Owned by: mww@…
Priority: High Milestone:
Component: ports Version: 1.3.2
Keywords: Cc:
Port:

Description

If you install gettext before you install findutils, then the gnufind binary will link against libiconv's and gettext's libraries.

$ otool -L /opt/local/bin/gnufind
/opt/local/bin/gnufind:
        /opt/local/lib/libintl.8.dylib (compatibility version 9.0.0, current version 9.0.0)
        /opt/local/lib/libiconv.2.dylib (compatibility version 7.0.0, current version 7.0.0)
        /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 88.3.4)
        /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation (compatibility version 150.0.0, current version 368.27.0)

If you go to uninstall gettext and/or libiconv, then it seems like a good idea that port should know about the dependency.

So I think we should have findutils depend upon gettext.

This patch fixes this.

It also adds a no_program_prefix variant as I discussed in

http://lists.macosforge.org/pipermail/macports-dev/2006-October/000096.html

Regards, Blair

Attachments (1)

Portfile (905 bytes) - added by blair (Blair Zajac) 14 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 14 years ago by blair (Blair Zajac)

I'm going to send in a new version of the Portfile that has the following changes:

  • set SORT=/usr/bin/sort to prevent problems of configure finding another sort program, which when removed from the system, will prevent locate from working.
  • update your email address
  • add a normal_names variant which creates symlinks from ${prefix}/bin/g* to the non-g names.
  • changed the prefix from gnu to g to be consistent with the majority of other MacPorts packages.
  • depend upon gettext.

Regards, Blair

comment:2 Changed 14 years ago by blair (Blair Zajac)

I decided that the variant name normal_names wasn't too clear, so I've renamed it to normal_install_names, leaving open the possibility of also adding symlinks for files just not in $prefix/bin.

Regards, Blair

Changed 14 years ago by blair (Blair Zajac)

Attachment: Portfile added

comment:3 Changed 14 years ago by blair (Blair Zajac)

Given the policy mentioned at the following URL of waiting 72 hours for the port maintainer to respond to the ticket, with no response, I committed the changes myself in r20214.

http://darwinports.opendarwin.org/docs/ch14s02.html#id1002379

I'll close this ticket myself when I get the Trac rights :)

Regards, Blair

comment:4 Changed 14 years ago by blair (Blair Zajac)

Resolution: fixed
Status: newclosed

Closing.

Note: See TracTickets for help on using tickets.