Opened 14 years ago

Closed 14 years ago

#10853 closed enhancement (fixed)

[PATCH] Add no_program_prefix variant to GNU ports

Reported by: blair (Blair Zajac) Owned by: yeled@…
Priority: Low Milestone:
Component: ports Version: 1.3.2
Keywords: Cc: blair (Blair Zajac)
Port:

Description

Here's a patch to add a no_program_prefix variant which removes the --program-prefix from configure.

I brought this up here:

http://lists.macosforge.org/pipermail/macports-dev/2006-October/000096.html

Regards, Blair

Attachments (1)

Portfile (1.5 KB) - added by blair (Blair Zajac) 14 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 14 years ago by blair (Blair Zajac)

Here's the patch. And toby@… cannot be selected in the assigned to field.

--- Portfile    (revision 20001)
+++ Portfile    (working copy)
@@ -29,3 +29,7 @@
        file delete -force ${destroot}${prefix}/share/info/dir
        file delete -force ${destroot}${prefix}/lib/charset.alias
 }
+
+variant no_program_prefix {
+       configure.args-delete   --program-prefix=g
+}

comment:2 Changed 14 years ago by markd@…

Cc: blair@… added

What port is this patch for?

comment:3 Changed 14 years ago by markd@…

Summary: [PATCH] Add no_program_prefix variant[PATCH] Add no_program_prefix variant to GNU ports

Oh yes, the link explains. Nevermind.

comment:4 Changed 14 years ago by blair (Blair Zajac)

A follow up to my original email raised the point that other ports cannot depend upon a binary's path if we remove the --program-prefix configure argument, say they can rely upon 'gsed'.

So I think a better solution is to keep the --program-prefix but add a variant that adds symlinks for all the binaries installed by the package.

I'll work on a patch for this.

Regards, Blair

comment:5 Changed 14 years ago by blair (Blair Zajac)

I'm uploading a new version of the Portfile for coreutils.

This version does the following:

  • a new variant named normal_names that creates symlinks for all the $prefix/bin/g* files.

the build still uses --program-prefix=g

  • updates to the latest coreutils version
  • enables the testsuite

Regards, Blair

comment:6 Changed 14 years ago by blair (Blair Zajac)

I decided that the variant name normal_names wasn't too clear, so I've renamed it to normal_install_names, leaving open the possibility of also adding symlinks for files just not in $prefix/bin.

Regards, Blair

Changed 14 years ago by blair (Blair Zajac)

Attachment: Portfile added

comment:7 Changed 14 years ago by blair (Blair Zajac)

Given the policy mentioned at the following URL of waiting 72 hours for the port maintainer to respond to the ticket, with no response, I committed the changes myself in r20215.

http://darwinports.opendarwin.org/docs/ch14s02.html#id1002379

I'll close this ticket myself when I get the Trac rights :)

Regards, Blair

comment:8 Changed 14 years ago by tobypeterson

Never got any notification of this (though I might have missed it, I get a lot of email). This is problematic for a few reasons. One potential issue is that there are a number of ports (can't think of any off hand) that depend on having the "g" prefix there. For example, you'll see a dependency like bin:gblah:coreutils. This variant will essentially break those ports.

comment:9 Changed 14 years ago by blair (Blair Zajac)

Resolution: fixed
Status: newclosed

Hi,

There's no problem in this port, since the prefix never changed. The files are all installed with the g prefix, it's just that with the normal_install_names variant, it also creates symlinks from the g* names to the non-g* names.

BTW, some other ports did have their prefix changed, but not this one.

Also, resolving as fixed.

Regards, Blair

Note: See TracTickets for help on using tickets.