Opened 18 years ago

Closed 17 years ago

Last modified 15 years ago

#10907 closed defect (fixed)

BUG: elvis does not respect destroot

Reported by: ehainry@… Owned by: yeled@…
Priority: High Milestone:
Component: ports Version:
Keywords: Cc: mike@…
Port:

Description

port destroot elvis puts some files directly in ${prefix}/share/elvis and some other directories. Even worse, it puts a README file in /etc/elvis. Ports are not supposed to write anything outside of /opt/local/.

I have started patching the Portfile. I do not think the destroot.destdir should be used this way, but however, it is now

destroot.destdir  BINDIR=${destroot}${prefix}/bin \
                  LIBDIR=${destroot}${prefix}/share/elvis \
                  DOCDIR=${destroot}${prefix}/share/doc/elvis \
                  MANDIR=${destroot}${prefix}/share/man \
                  DATADIR=${destroot}${prefix}/share/elvis/

The next problem is the installation of manpages which uses a "clever" script: instman.sh and then the problem of /etc/elvis. It is going to require patching the Makefile so that it does not use instman.sh but just installs in $MANDIR and changing this hard /etc to something else, probably ${prefix}/share/doc/elvis.

Attachments (1)

elvis.diff (2.0 KB) - added by ehainry@… 17 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 18 years ago by ehainry@…

This patch is not good enough: after install, elvis does not find its help files.

comment:2 Changed 17 years ago by pipping@…

Milestone: Available Ports

comment:3 Changed 17 years ago by pipping@…

Milestone: Available PortsPort Bugs

comment:4 Changed 17 years ago by ehainry@…

I have rewritten some parts of the Portfile. It now does everything as it should (does not write where it should not, finds its files however, installs man pages). Patch follows

Changed 17 years ago by ehainry@…

Attachment: elvis.diff added

comment:5 Changed 17 years ago by ehainry@…

Oh, by the way, the maintainer's address seems not to exist anymore: postfix tells me:

(Host or domain name not found. Name service error for name=gene-hacker.net type=MX: Host not found, try again)

comment:6 Changed 17 years ago by pipping@…

Resolution: fixed
Status: newclosed

fixed in r24144.

comment:7 Changed 15 years ago by (none)

Milestone: Port Bugs

Milestone Port Bugs deleted

Note: See TracTickets for help on using tickets.